Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-11-16 Thread Charles Baylis
Backported r227407 to gcc-5-branch following approval on IRC. The patch applied without conflicts. 2015-11-16 Charles Baylis Backport from mainline r227407 PR ipa/67280 * cgraphunit.c (cgraph_node::create_wrapper): Set can_throw_external in new callgraph edge.

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-09-20 Thread Charles Baylis
On 7 September 2015 at 09:35, Charles Baylis wrote: >>> >gcc/ChangeLog: >>> > >>> >2015-08-28 Charles Baylis >>> > >>> > * cgraphunit.c (cgraph_node::create_wrapper): Set >>> > can_throw_external >>> > in new callgraph edge. > > Committed to trunk as r227407. > > Are you happy

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-09-07 Thread Ramana Radhakrishnan
On Mon, Sep 7, 2015 at 9:35 AM, Charles Baylis wrote: > On 2 September 2015 at 13:09, Jan Hubicka wrote: >> It kind of sucks that one needs to mind this flag each time one creates edge, >> but setting the value in create_edge is not quite correct as that one does >> not >> have any information o

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-09-07 Thread Charles Baylis
On 2 September 2015 at 13:09, Jan Hubicka wrote: > It kind of sucks that one needs to mind this flag each time one creates edge, > but setting the value in create_edge is not quite correct as that one does not > have any information on where the call appears and if the exception is not > handled

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-09-02 Thread Jan Hubicka
> >This patch is an attempt to fix > >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67280. I have written up > >an analysis of the bug there. > > > >When cgraph_node::create_wrapper() updates the callgraph for the new > >function, it sets the can_throw_external flag to false, even when > >wrapping a

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-09-01 Thread Jeff Law
On 08/28/2015 09:03 AM, Charles Baylis wrote: Hi This patch is an attempt to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67280. I have written up an analysis of the bug there. When cgraph_node::create_wrapper() updates the callgraph for the new function, it sets the can_throw_external flag