Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-02-12 Thread Ilya Verbin
On Tue, Feb 10, 2015 at 11:20:24 +0100, Jakub Jelinek wrote: > So, what we can do is e.g. ignore the nested #pragma omp target* regions > inside of #pragma omp target, or turn them into __builtin_trap (). I like this idea to ignore them at compile-time, but how to be with declare target functions?

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-02-10 Thread Thomas Schwinge
Hi! On Tue, 10 Feb 2015 11:20:24 +0100, Jakub Jelinek wrote: > On Tue, Feb 10, 2015 at 11:16:22AM +0100, Martin Jambor wrote: > > On Mon, Jan 12, 2015 at 12:22:44AM +0300, Ilya Verbin wrote: > > > Currently if a target* pragma appears within a target region, GCC > > > successfully > > > compiles

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-02-10 Thread Jakub Jelinek
On Tue, Feb 10, 2015 at 11:16:22AM +0100, Martin Jambor wrote: > On Mon, Jan 12, 2015 at 12:22:44AM +0300, Ilya Verbin wrote: > > Currently if a target* pragma appears within a target region, GCC > > successfully > > compiles such code (with a warning). But the binary fails at run-time, > > sinc

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-02-10 Thread Martin Jambor
Hi, On Mon, Jan 12, 2015 at 12:22:44AM +0300, Ilya Verbin wrote: > Hi! > > Currently if a target* pragma appears within a target region, GCC successfully > compiles such code (with a warning). But the binary fails at run-time, since > it > tries to call GOMP_target* functions on target. > > Th

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-02-09 Thread Ilya Verbin
On 02 Feb 13:15, Jakub Jelinek wrote: > On Mon, Jan 12, 2015 at 12:22:44AM +0300, Ilya Verbin wrote: > > Currently if a target* pragma appears within a target region, GCC > > successfully > > compiles such code (with a warning). But the binary fails at run-time, > > since it > > tries to call GO

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-02-02 Thread Jakub Jelinek
On Mon, Jan 12, 2015 at 12:22:44AM +0300, Ilya Verbin wrote: > Currently if a target* pragma appears within a target region, GCC successfully > compiles such code (with a warning). But the binary fails at run-time, since > it > tries to call GOMP_target* functions on target. > > The spec says: "

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-01-28 Thread Ilya Verbin
Hi Jakub! We have 3 pending patches with warnings/errors about omp pragmas: 1. https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00617.html 2. https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00621.html 3. This one. What should we do with them? [ ] Rebase and continue pinging. [ ] Postpone until Stage