Re: [PATCH][PR116569] match.pd: Check trunc_mod vector obtap before folding.

2024-09-18 Thread Richard Biener
On Wed, 18 Sep 2024, Jennifer Schmitz wrote: > > > > On 6 Sep 2024, at 16:20, Jakub Jelinek wrote: > > > > External email: Use caution opening links or attachments > > > > > > On Fri, Sep 06, 2024 at 02:10:19PM +, Kyrylo Tkachov wrote: > >>> This is certainly wrong. > >>> PROP_gimple_any

Re: [PATCH][PR116569] match.pd: Check trunc_mod vector obtap before folding.

2024-09-18 Thread Jennifer Schmitz
> On 6 Sep 2024, at 16:20, Jakub Jelinek wrote: > > External email: Use caution opening links or attachments > > > On Fri, Sep 06, 2024 at 02:10:19PM +, Kyrylo Tkachov wrote: >>> This is certainly wrong. >>> PROP_gimple_any is set already at the end of gimplification, so certainly >>> doe

Re: [PATCH][PR116569] match.pd: Check trunc_mod vector obtap before folding.

2024-09-06 Thread Jakub Jelinek
On Fri, Sep 06, 2024 at 02:10:19PM +, Kyrylo Tkachov wrote: > > This is certainly wrong. > > PROP_gimple_any is set already at the end of gimplification, so certainly > > doesn't include any other early gimple passes. > > And, not all statements are folded during gimplification, e.g. in OpenMP

Re: [PATCH][PR116569] match.pd: Check trunc_mod vector obtap before folding.

2024-09-06 Thread Kyrylo Tkachov
> On 6 Sep 2024, at 16:00, Jakub Jelinek wrote: > > External email: Use caution opening links or attachments > > > On Fri, Sep 06, 2024 at 01:46:01PM +, Jennifer Schmitz wrote: >> In the pattern X - (X / Y) * Y to X % Y, this patch guards the >> simplification for vector types by a check

Re: [PATCH][PR116569] match.pd: Check trunc_mod vector obtap before folding.

2024-09-06 Thread Jakub Jelinek
On Fri, Sep 06, 2024 at 01:46:01PM +, Jennifer Schmitz wrote: > In the pattern X - (X / Y) * Y to X % Y, this patch guards the > simplification for vector types by a check for: > 1) Support of the mod optab for vectors OR > 2) Application during early gimple passes (using PROP_gimple_any). > Th