Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-28 Thread Jakub Jelinek
On Fri, Nov 28, 2014 at 02:52:11AM +0300, Ilya Verbin wrote: > On 21 Nov 21:36, Jakub Jelinek wrote: > > On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: > > > '#pragma omp critical (name)' can be placed in the function, marked > > > with '#pragma omp declare target', in this case the c

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-27 Thread Ilya Verbin
On 21 Nov 21:36, Jakub Jelinek wrote: > On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: > > '#pragma omp critical (name)' can be placed in the function, marked > > with '#pragma omp declare target', in this case the corresponding node > > should be marked as offloadable too. > > Bootst

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Ilya Verbin
> On 22 Nov 2014, at 00:11, H.J. Lu wrote: > > Have you fixed the offloading issue with binutils 2.25? No, I'm still thinking how to make a patch better than the former... Probably will send it on Monday. (Regressions in make check disappeared after disabling offload IR in default configura

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 12:08:38AM +0300, Ilya Verbin wrote: > > On 21 Nov 2014, at 23:36, Jakub Jelinek wrote: > > > >> On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: > >> Hi, > >> > >> '#pragma omp critical (name)' can be placed in the function, marked > >> with '#pragma omp decl

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread H.J. Lu
On Fri, Nov 21, 2014 at 1:08 PM, Ilya Verbin wrote: >> On 21 Nov 2014, at 23:36, Jakub Jelinek wrote: >> >>> On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: >>> Hi, >>> >>> '#pragma omp critical (name)' can be placed in the function, marked >>> with '#pragma omp declare target', in t

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Ilya Verbin
> On 21 Nov 2014, at 23:36, Jakub Jelinek wrote: > >> On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: >> Hi, >> >> '#pragma omp critical (name)' can be placed in the function, marked >> with '#pragma omp declare target', in this case the corresponding node >> should be marked as off

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: > Hi, > > '#pragma omp critical (name)' can be placed in the function, marked > with '#pragma omp declare target', in this case the corresponding node > should be marked as offloadable too. > Bootstrapped/regtested on x86_64-linux and i6