Re: [PATCH][LTO/PGO] Warn when both -flto and -fprofile-generate are enabled

2014-04-02 Thread Jan Hubicka
> On Wed, Apr 2, 2014 at 2:07 PM, Richard Biener > wrote: > > On Wed, Apr 2, 2014 at 1:50 PM, Markus Trippelsdorf > > wrote: > >> It is a common mistake to enable both -flto and -fprofile-generate when > >> building projects. This is not a good idea, because memory use will > >> skyrocket due to

Re: [PATCH][LTO/PGO] Warn when both -flto and -fprofile-generate are enabled

2014-04-02 Thread Richard Biener
On Wed, Apr 2, 2014 at 2:07 PM, Richard Biener wrote: > On Wed, Apr 2, 2014 at 1:50 PM, Markus Trippelsdorf > wrote: >> It is a common mistake to enable both -flto and -fprofile-generate when >> building projects. This is not a good idea, because memory use will >> skyrocket due to instrumentatio

Re: [PATCH][LTO/PGO] Warn when both -flto and -fprofile-generate are enabled

2014-04-02 Thread Richard Biener
On Wed, Apr 2, 2014 at 1:50 PM, Markus Trippelsdorf wrote: > It is a common mistake to enable both -flto and -fprofile-generate when > building projects. This is not a good idea, because memory use will > skyrocket due to instrumentation. So just warn the user. > > OK for next stage1? I'd rather

Re: [PATCH][LTO/PGO] Warn when both -flto and -fprofile-generate are enabled

2014-04-02 Thread Marek Polacek
On Wed, Apr 02, 2014 at 01:50:31PM +0200, Markus Trippelsdorf wrote: > + if (opts->x_flag_generate_lto && opts->x_flag_profile_generate) > +warning_at (loc, 0, "Enabling both -fprofile-generate and -flto is a bad > idea."); s/Enabling/enabling/ + no dot at the end. Marek