Re: [PATCH][C++] Fix PR67333

2015-10-18 Thread Jason Merrill
On 10/17/2015 08:57 AM, Mikhail Maltsev wrote: On 10/06/2015 04:46 PM, Jason Merrill wrote: Hi, sorry for the slow response. Please feel free to ping once a week. On 08/27/2015 02:27 PM, Mikhail Maltsev wrote: + if (TREE_THIS_VOLATILE (t) && (!DECL_P (t) || want_rval)) Why the !DECL_P chec

Re: [PATCH][C++] Fix PR67333

2015-10-17 Thread Mikhail Maltsev
On 10/06/2015 04:46 PM, Jason Merrill wrote: > Hi, sorry for the slow response. Please feel free to ping once a week. > > On 08/27/2015 02:27 PM, Mikhail Maltsev wrote: >> + if (TREE_THIS_VOLATILE (t) && (!DECL_P (t) || want_rval)) > > Why the !DECL_P check? Pulling the value out of a volatile

Re: [PATCH][C++] Fix PR67333

2015-10-06 Thread Jason Merrill
Hi, sorry for the slow response. Please feel free to ping once a week. On 08/27/2015 02:27 PM, Mikhail Maltsev wrote: + if (TREE_THIS_VOLATILE (t) && (!DECL_P (t) || want_rval)) Why the !DECL_P check? Pulling the value out of a volatile INDIRECT_REF is just as problematic as from a variabl