Re: [PATCH][AArch64] Add a SHA1H pattern

2016-10-28 Thread James Greenhalgh
On Fri, Oct 28, 2016 at 04:54:05PM +0100, Wilco Dijkstra wrote: > James Greenhalgh wrote: > > On Wed, Oct 26, 2016 at 12:11:44PM +, Wilco Dijkstra wrote: > > > Add a SHA1H pattern with a V2SI input.  This avoids unnecessary > > > DUPs when using intrinsics like vsha1h_u32 (vgetq_lane_u32 (x, 0)

Re: [PATCH][AArch64] Add a SHA1H pattern

2016-10-28 Thread Wilco Dijkstra
James Greenhalgh wrote: > On Wed, Oct 26, 2016 at 12:11:44PM +, Wilco Dijkstra wrote: > > Add a SHA1H pattern with a V2SI input.  This avoids unnecessary > > DUPs when using intrinsics like vsha1h_u32 (vgetq_lane_u32 (x, 0)). > > I think this is incorrect for big endian - element 0 of a vec_sel

Re: [PATCH][AArch64] Add a SHA1H pattern

2016-10-26 Thread James Greenhalgh
On Wed, Oct 26, 2016 at 12:11:44PM +, Wilco Dijkstra wrote: > Add a SHA1H pattern with a V2SI input. This avoids unnecessary > DUPs when using intrinsics like vsha1h_u32 (vgetq_lane_u32 (x, 0)). I think this is incorrect for big endian - element 0 of a vec_select in big-endian for V4SImode is