Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c

2015-04-07 Thread Alan Lawrence
Done - committed as r221905, and PR target/65689 filed on bugzilla. Cheers, Alan James Greenhalgh wrote: On Wed, Mar 25, 2015 at 06:27:49PM +, James Greenhalgh wrote: I think your original patch to add -O is just fine, but Marcus or Richard will need to approve it. I haven't seen any how

Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c

2015-04-07 Thread James Greenhalgh
On Wed, Mar 25, 2015 at 06:27:49PM +, James Greenhalgh wrote: > I think your original patch to add -O is just fine, but Marcus or > Richard will need to approve it. I haven't seen any howls of objection from Marcus/Richard on this. As you say, your preferred fix for the "S" constraint is far

Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c

2015-03-26 Thread Alan Lawrence
So I've dug into this a bit further, as follows. Firstly, changing the test (without -O) to use an 'i' constraint, fixes the test (however, an "i" constraint is not correct for the instructions/asm where the "S" constraint is used, e.g. in the Linux kernel). This is because parse_input_constra

Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c

2015-03-25 Thread James Greenhalgh
On Tue, Mar 24, 2015 at 05:46:57PM +, Alan Lawrence wrote: > Hmmm. This is not the right fix: the tests Richard fixed, were failing because > of lack of constant propagation and DCE at compile-time, which then didn't > eliminate the call to link_error. The AArch64 test is failing because this

Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c

2015-03-24 Thread Alan Lawrence
Hmmm. This is not the right fix: the tests Richard fixed, were failing because of lack of constant propagation and DCE at compile-time, which then didn't eliminate the call to link_error. The AArch64 test is failing because this from aarch64/constraints.md: (define_constraint "S" "A constraint