Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-08-04 Thread James Greenhalgh
On Tue, Aug 04, 2015 at 09:58:37AM +0100, Kyrill Tkachov wrote: > > On 04/08/15 09:53, James Greenhalgh wrote: > > On Mon, Aug 03, 2015 at 04:20:13PM +0100, Kyrill Tkachov wrote: > >> Ok, I've removed usages of 'ret' in favor of returning when appropriate. > >> In this last one I left the ret (but

Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-08-04 Thread Kyrill Tkachov
On 04/08/15 09:53, James Greenhalgh wrote: On Mon, Aug 03, 2015 at 04:20:13PM +0100, Kyrill Tkachov wrote: Ok, I've removed usages of 'ret' in favor of returning when appropriate. In this last one I left the ret (but cleaned up the control flow a bit) because if the processing fails we need to

Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-08-04 Thread James Greenhalgh
On Mon, Aug 03, 2015 at 04:20:13PM +0100, Kyrill Tkachov wrote: > Ok, I've removed usages of 'ret' in favor of returning when appropriate. > In this last one I left the ret (but cleaned up the control flow a bit) > because if the processing fails we need to clean up a bit of state before > returnin

Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-08-03 Thread Kyrill Tkachov
On 03/08/15 11:52, James Greenhalgh wrote: On Fri, Jul 24, 2015 at 11:43:32AM +0100, Kyrill Tkachov wrote: On 21/07/15 16:37, James Greenhalgh wrote: On Thu, Jul 16, 2015 at 04:20:59PM +0100, Kyrill Tkachov wrote: Hi all, This patch implements target attribute support via the TARGET_OPTION_

Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-08-03 Thread James Greenhalgh
On Fri, Jul 24, 2015 at 11:43:32AM +0100, Kyrill Tkachov wrote: > > On 21/07/15 16:37, James Greenhalgh wrote: > > On Thu, Jul 16, 2015 at 04:20:59PM +0100, Kyrill Tkachov wrote: > >> Hi all, > >> > >> This patch implements target attribute support via the > >> TARGET_OPTION_VALID_ATTRIBUTE_P hoo

Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-07-24 Thread Kyrill Tkachov
On 21/07/15 16:37, James Greenhalgh wrote: On Thu, Jul 16, 2015 at 04:20:59PM +0100, Kyrill Tkachov wrote: Hi all, This patch implements target attribute support via the TARGET_OPTION_VALID_ATTRIBUTE_P hook. The aarch64_handle_option function in common/config/aarch64/aarch64-common.c is expo

Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-07-24 Thread Marcus Shawcroft
On 21 July 2015 at 16:37, James Greenhalgh wrote: > On Thu, Jul 16, 2015 at 04:20:59PM +0100, Kyrill Tkachov wrote: >> +static bool >> +aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr) >> +{ >> + bool ret; >> + bool invert = false; >> + >> + int len = strlen (arg_str

Re: [PATCH][AArch64][8/14] Implement TARGET_OPTION_VALID_ATTRIBUTE_P

2015-07-21 Thread James Greenhalgh
On Thu, Jul 16, 2015 at 04:20:59PM +0100, Kyrill Tkachov wrote: > Hi all, > > This patch implements target attribute support via the > TARGET_OPTION_VALID_ATTRIBUTE_P hook. > The aarch64_handle_option function in common/config/aarch64/aarch64-common.c > is exported to the > backend and beefed up