Fwd: Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-24 Thread Tom de Vries
[ forwarding. for some reason, this email didn't make it to gcc-patches ml archive ] Forwarded Message Subject: Re: [PATCH][4/5] Handle internal_fn in operand_equal_p Date: Mon, 23 Feb 2015 10:03:34 +0100 From: Richard Biener To: Tom de Vries CC: Jakub Jelinek , GCC Pa

Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-23 Thread Richard Biener
On Sun, 22 Feb 2015, Tom de Vries wrote: > On 20-02-15 12:54, Richard Biener wrote: > > On Thu, 19 Feb 2015, Tom de Vries wrote: > > > > > On 19-02-15 14:07, Richard Biener wrote: > > > > On Thu, 19 Feb 2015, Jakub Jelinek wrote: > > > > > > > > > On Thu, Feb 19, 2015 at 01:44:46PM +0100, Richar

Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-22 Thread Tom de Vries
On 20-02-15 12:54, Richard Biener wrote: On Thu, 19 Feb 2015, Tom de Vries wrote: On 19-02-15 14:07, Richard Biener wrote: On Thu, 19 Feb 2015, Jakub Jelinek wrote: On Thu, Feb 19, 2015 at 01:44:46PM +0100, Richard Biener wrote: I'd call it a bug though, and we do have internal fns in gener

Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-20 Thread Richard Biener
On Thu, 19 Feb 2015, Tom de Vries wrote: > On 19-02-15 14:07, Richard Biener wrote: > > On Thu, 19 Feb 2015, Jakub Jelinek wrote: > > > > > On Thu, Feb 19, 2015 at 01:44:46PM +0100, Richard Biener wrote: > > > > I'd call it a bug though, and we do have internal fns in > > > > generic already thus

Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-19 Thread Tom de Vries
On 19-02-15 14:07, Richard Biener wrote: On Thu, 19 Feb 2015, Jakub Jelinek wrote: On Thu, Feb 19, 2015 at 01:44:46PM +0100, Richard Biener wrote: I'd call it a bug though, and we do have internal fns in generic already thus the issue is latent (with ubsan at least). Which means ok for trunk

Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-19 Thread Richard Biener
On Thu, 19 Feb 2015, Jakub Jelinek wrote: > On Thu, Feb 19, 2015 at 01:44:46PM +0100, Richard Biener wrote: > > I'd call it a bug though, and we do have internal fns in > > generic already thus the issue is latent (with ubsan at least). > > > > Which means ok for trunk now. > > But the patch sho

Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-19 Thread Richard Biener
On Thu, 19 Feb 2015, Tom de Vries wrote: > On 19-02-15 11:29, Tom de Vries wrote: > > Hi, > > > > I'm posting this patch series for stage1: > > - 0001-Disable-lang_hooks.gimplify_expr-in-free_lang_data.patch > > - 0002-Add-gimple_find_sub_bbs.patch > > - 0003-Factor-optimize_va_list_gpr_fpr_size-

Re: [PATCH][4/5] Handle internal_fn in operand_equal_p

2015-02-19 Thread Jakub Jelinek
On Thu, Feb 19, 2015 at 01:44:46PM +0100, Richard Biener wrote: > I'd call it a bug though, and we do have internal fns in > generic already thus the issue is latent (with ubsan at least). > > Which means ok for trunk now. But the patch should better handle the internal calls right. I.e. return 0