Re: [PATCH]: libgompd add parallel handle functions

2022-06-06 Thread Jakub Jelinek via Gcc-patches
On Mon, Jun 06, 2022 at 07:32:31PM +0200, Mohamed Atef wrote: > So for both cases one should read the value of *team and if it's NULL, the > function returns some error state (eg. ompd_rc_unavailable) No, I think for team NULL it should simply push something different to ompd_parallel_handle_t, so

Re: [PATCH]: libgompd add parallel handle functions

2022-06-06 Thread Jakub Jelinek via Gcc-patches
On Mon, Jun 06, 2022 at 05:13:24PM +0200, Mohamed Sayed via Gcc-patches wrote: > > 2022-06-06 Mohamed Sayed > > > > > > * Makefile.am: (libgompd_la_SOURCES): Add ompd-parallel.c. The ChangeLog formatting is wrong. The above line should be: * Makefile.am (libgompd_la_SOURCES): Add ompd-

Re: [PATCH]: libgompd add parallel handle functions

2022-06-06 Thread Mohamed Atef via Gcc-patches
في الاثنين، ٦ يونيو، ٢٠٢٢ ٧:١٣ م Jakub Jelinek via Gcc-patches < gcc-patches@gcc.gnu.org> كتب: > On Mon, Jun 06, 2022 at 01:48:22AM +0200, Mohamed Sayed via Gcc-patches > wrote: > > This patch adds parallel region handles specified in section 5.5.3. > > >From examining libgomp code, I found that s

Re: [PATCH]: libgompd add parallel handle functions

2022-06-06 Thread Jakub Jelinek via Gcc-patches
On Mon, Jun 06, 2022 at 01:48:22AM +0200, Mohamed Sayed via Gcc-patches wrote: > This patch adds parallel region handles specified in section 5.5.3. > >From examining libgomp code, I found that struct gomp_team describes the > parallel region. I think it would be nice to first find out what the di

Re: [PATCH]: libgompd add parallel handle functions

2022-06-06 Thread Mohamed Sayed via Gcc-patches
This is the final diff On Mon, Jun 6, 2022 at 1:48 AM Mohamed Sayed wrote: > This patch adds parallel region handles specified in section 5.5.3. > From examining libgomp code, I found that struct gomp_team describes the > parallel region. > The Thread handle gives the address of gomp_thread so,