Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-18 Thread Jeff Law
On 9/18/18 1:52 AM, Andreas Schwab wrote: > On Sep 17 2018, Jeff Law wrote: > >> On 9/17/18 3:08 AM, Andreas Schwab wrote: >>> PR rtl-optimization/85458 >>> * sel-sched.c (sel_target_adjust_priority): Remove wrong >>> assertion. >> Under what conditions is the new priority negative?

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-18 Thread Andreas Schwab
On Sep 17 2018, Jeff Law wrote: > On 9/17/18 3:08 AM, Andreas Schwab wrote: >> PR rtl-optimization/85458 >> * sel-sched.c (sel_target_adjust_priority): Remove wrong >> assertion. > Under what conditions is the new priority negative? Without digging > deep into the ia64 port that j

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-17 Thread Jeff Law
On 9/17/18 3:08 AM, Andreas Schwab wrote: > PR rtl-optimization/85458 > * sel-sched.c (sel_target_adjust_priority): Remove wrong > assertion. Under what conditions is the new priority negative? Without digging deep into the ia64 port that just seems wrong. jeff

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-17 Thread Andreas Schwab
On Sep 17 2018, John David Anglin wrote: > On 2018-09-17 5:08 AM, Andreas Schwab wrote: >> PR rtl-optimization/85458 >> * sel-sched.c (sel_target_adjust_priority): Remove wrong >> assertion. >> >> diff --git a/gcc/sel-sched.c b/gcc/sel-sched.c >> index 824f1ec340..1be977d70b 100644

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-17 Thread John David Anglin
On 2018-09-17 5:08 AM, Andreas Schwab wrote: PR rtl-optimization/85458 * sel-sched.c (sel_target_adjust_priority): Remove wrong assertion. diff --git a/gcc/sel-sched.c b/gcc/sel-sched.c index 824f1ec340..1be977d70b 100644 --- a/gcc/sel-sched.c +++ b/gcc/sel-sched.c @@ -33

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-17 Thread Andreas Schwab
PR rtl-optimization/85458 * sel-sched.c (sel_target_adjust_priority): Remove wrong assertion. diff --git a/gcc/sel-sched.c b/gcc/sel-sched.c index 824f1ec340..1be977d70b 100644 --- a/gcc/sel-sched.c +++ b/gcc/sel-sched.c @@ -3330,8 +3330,6 @@ sel_target_adjust_priority (exp

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-10 Thread John David Anglin
On 2018-09-10 8:35 AM, Andreas Schwab wrote: On Sep 06 2018, Jeff Law wrote: On 09/03/2018 08:32 AM, John David Anglin wrote: The documentation for TARGET_SCHED_ADJUST_PRIORITY indicates that the hook can reduce the priority of INSN to execute it later.  The hppa hook only reduces the priorit

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-10 Thread Andreas Schwab
On Sep 06 2018, Jeff Law wrote: > On 09/03/2018 08:32 AM, John David Anglin wrote: >> The documentation for TARGET_SCHED_ADJUST_PRIORITY indicates that the >> hook can >> reduce the priority of INSN to execute it later.  The hppa hook only >> reduces the priority >> and it has been this way for y

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-06 Thread Jeff Law
On 09/03/2018 08:32 AM, John David Anglin wrote: > The documentation for TARGET_SCHED_ADJUST_PRIORITY indicates that the > hook can > reduce the priority of INSN to execute it later.  The hppa hook only > reduces the priority > and it has been this way for years.  However, the assert in > sel_targe