Re: [PATCH], Add check ppc_cpu_supports_hw to testsuite

2017-06-28 Thread Segher Boessenkool
On Wed, Jun 28, 2017 at 05:04:37PM -0400, Michael Meissner wrote: > > Why did you use check_runtime_nocache btw? Is that just copy-paste? > > Just copy-paste. > > Like the target_clones stuff, right now, it is only x86 and PowerPC that > supports __builtin_cpu*. > > I don't really see the point

Re: [PATCH], Add check ppc_cpu_supports_hw to testsuite

2017-06-28 Thread Michael Meissner
On Wed, Jun 28, 2017 at 03:48:50PM -0500, Segher Boessenkool wrote: > As Peter said, I'd rather test for "ppc32", so this works anywhere. Fair enough. > That would give > > proc check_cpu_supports_available { } { > if { [istarget powerpc*-*-*] } { > return [check_runtime cpu_supports

Re: [PATCH], Add check ppc_cpu_supports_hw to testsuite

2017-06-28 Thread Segher Boessenkool
Hi! On Tue, Jun 27, 2017 at 07:53:21PM -0400, Michael Meissner wrote: > --- gcc/testsuite/lib/target-supports.exp (revision 249606) > +++ gcc/testsuite/lib/target-supports.exp (working copy) > @@ -1930,6 +1930,37 @@ proc check_effective_target_powerpc64_no > } {-O2}] > } > > +# Re

Re: [PATCH], Add check ppc_cpu_supports_hw to testsuite

2017-06-28 Thread Michael Meissner
On Wed, Jun 28, 2017 at 09:58:40AM -0500, Peter Bergner wrote: > On 6/27/17 6:53 PM, Michael Meissner wrote: > > This adds a target supports option in dejagnu so that future tests can use > > this > > to determine whether or not to test target_clones. > > I like the idea, but some comments... >

Re: [PATCH], Add check ppc_cpu_supports_hw to testsuite

2017-06-28 Thread Peter Bergner
On 6/27/17 6:53 PM, Michael Meissner wrote: > This adds a target supports option in dejagnu so that future tests can use > this > to determine whether or not to test target_clones. I like the idea, but some comments... > + #ifdef __MACH__ > + asm volatile ("xxlor vs0,

Re: [PATCH], Add check ppc_cpu_supports_hw to testsuite

2017-06-27 Thread Jeff Law
On 06/27/2017 05:53 PM, Michael Meissner wrote: > The PowerPC __builtin_cpu_supports and __builtin_cpu_is built-in functions > require GLIBC 2.23, since they use fixed words at the end of thread control > area to store the HWCAP and HWCAP2 bits. If the compiler was not configured > with the approp