RE: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-06 Thread Toma Tabacu
> From: Catherine Moore > > This patch fixes my original objection. Thanks. > Committed as r245921. Thanks, Toma

RE: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-02 Thread Moore, Catherine
> -Original Message- > From: Toma Tabacu [mailto:toma.tab...@imgtec.com] > Sent: Thursday, March 2, 2017 11:47 AM > To: Rainer Orth > Cc: Moore, Catherine ; gcc- > patc...@gcc.gnu.org; Matthew Fortune > > Subject: RE: [PATCH,testsuite] Skip gcc.dg/lto/pr6044

RE: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-02 Thread Toma Tabacu
Hi, > From: Rainer Orth > > > > gcc/testsuite/ > > > > * gcc.dg/lto/pr60449_0.c: Add dg-require-effective-target for > > gettimeofday. Remove dg-skip-if for AVR. > > Two spaces after period. > Fixed. > > * lib/target-supports.exp (check_effective_target_gettimeofday): New. > > Bet

Re: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-02 Thread Rainer Orth
Hi Toma, >> that's not what I suggested (or at least meant to suggest): having >> gettimeofday as an effective-target keyword (like setrlimit, mmap, and >> others) is the way to go, just your previous implementation of >> check_effective_target_gettimeofday was problematic/unreliable. >> >> If yo

RE: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-02 Thread Toma Tabacu
Hi, > From: Rainer Orth > > that's not what I suggested (or at least meant to suggest): having > gettimeofday as an effective-target keyword (like setrlimit, mmap, and > others) is the way to go, just your previous implementation of > check_effective_target_gettimeofday was problematic/unreliable

Re: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-02 Thread Rainer Orth
Hi Toma, > As you suggested, I have added a check_gettimeofday_available proc in > target-supports.exp and a dg-require-gettimeofday proc in > target-supports-dg.exp > which check for gettimeofday using the existing check_function_available proc. that's not what I suggested (or at least meant to

RE: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-01 Thread Toma Tabacu
Hi Rainer, Thank you for the feedback. As you suggested, I have added a check_gettimeofday_available proc in target-supports.exp and a dg-require-gettimeofday proc in target-supports-dg.exp which check for gettimeofday using the existing check_function_available proc. The test still runs and pas

Re: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-01 Thread Rainer Orth
Hi Toma, > The patch below adds a dg_require_effective_target for gettimeofday. > Does it look good ? I'm having some doubts about the new directive's name. no, this has a couple of problems. See below. > Also, this patch makes the dg-skip-if for AVR redundant. Should I remove it ? Of course:

RE: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-03-01 Thread Toma Tabacu
> From: Catherine Moore > > Hi Toma, > There are some MIPS ELF targets that do support gettimeofday. Perhaps you > could handle this with a dg_require_effective_target entry for gettimeofday. > Thanks, > Catherine > Hi, Thank you for your quick reply. The patch below adds a dg_require_effect

RE: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

2017-02-28 Thread Moore, Catherine
> -Original Message- > From: Toma Tabacu [mailto:toma.tab...@imgtec.com] > Sent: Tuesday, February 28, 2017 9:32 AM > To: gcc-patches@gcc.gnu.org > Cc: Matthew Fortune ; Moore, > Catherine > Subject: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* > targets. > > Hi, > >