Re: [PATCH, rs6000] Fix alias set of link reg save MEM

2021-06-02 Thread Pat Haugen via Gcc-patches
On 6/2/21 9:19 AM, Segher Boessenkool wrote: > On Wed, Jun 02, 2021 at 08:23:48AM -0500, Pat Haugen wrote: >> On 6/2/21 7:01 AM, Richard Biener wrote: >>> So did you check the RTL (and alias-sets) produced by >>> __builtin_return_address? Test coverage might >>> be low here and w/o scheduling oppo

Re: [PATCH, rs6000] Fix alias set of link reg save MEM

2021-06-02 Thread Segher Boessenkool
On Wed, Jun 02, 2021 at 08:23:48AM -0500, Pat Haugen wrote: > On 6/2/21 7:01 AM, Richard Biener wrote: > > So did you check the RTL (and alias-sets) produced by > > __builtin_return_address? Test coverage might > > be low here and w/o scheduling opportunities to break things. > > __builtin_return

Re: [PATCH, rs6000] Fix alias set of link reg save MEM

2021-06-02 Thread Pat Haugen via Gcc-patches
On 6/2/21 7:01 AM, Richard Biener wrote: > On Wed, Jun 2, 2021 at 1:15 PM Pat Haugen wrote: >> >> On 6/2/21 1:51 AM, Richard Biener wrote: >>> On Tue, Jun 1, 2021 at 10:37 PM Pat Haugen via Gcc-patches >>> wrote: Make sure link reg save MEM has frame alias set, to match other link reg >

Re: [PATCH, rs6000] Fix alias set of link reg save MEM

2021-06-02 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 1:15 PM Pat Haugen wrote: > > On 6/2/21 1:51 AM, Richard Biener wrote: > > On Tue, Jun 1, 2021 at 10:37 PM Pat Haugen via Gcc-patches > > wrote: > >> > >> Make sure link reg save MEM has frame alias set, to match other link reg > >> save/restore code. > >> > >> Bootstrap/re

Re: [PATCH, rs6000] Fix alias set of link reg save MEM

2021-06-02 Thread Pat Haugen via Gcc-patches
On 6/2/21 1:51 AM, Richard Biener wrote: > On Tue, Jun 1, 2021 at 10:37 PM Pat Haugen via Gcc-patches > wrote: >> >> Make sure link reg save MEM has frame alias set, to match other link reg >> save/restore code. >> >> Bootstrap/regtest on powerpc64/powerpc64le with no new regressions. Ok for >> tr

Re: [PATCH, rs6000] Fix alias set of link reg save MEM

2021-06-01 Thread Richard Biener via Gcc-patches
On Tue, Jun 1, 2021 at 10:37 PM Pat Haugen via Gcc-patches wrote: > > Make sure link reg save MEM has frame alias set, to match other link reg > save/restore code. > > Bootstrap/regtest on powerpc64/powerpc64le with no new regressions. Ok for > trunk? > > -Pat > > > 2021-06-01 Pat Haugen > > gc

Re: [PATCH, rs6000] Fix alias set of link reg save MEM

2021-06-01 Thread Segher Boessenkool
On Tue, Jun 01, 2021 at 03:34:50PM -0500, Pat Haugen wrote: > Make sure link reg save MEM has frame alias set, to match other link reg > save/restore code. Okay for trunk and any backports (please do at least GCC 11). Thanks! Segher