Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-31 Thread Peter Bergner
On 7/26/19 9:28 AM, Iain Sandoe wrote: > The patch needs one small amendment to succeed in bootstrap. > I applied the amended to i686, x86_64 and powerpc Darwin with no apparent > new problems. From the Darwin perspective, the patch is OK with the > amendment. Ok, thanks. For completeness, I h

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-30 Thread Uros Bizjak
On Tue, Jul 30, 2019 at 5:33 PM Peter Bergner wrote: > > On 7/30/19 7:52 AM, Uros Bizjak wrote: > > On Thu, Jul 25, 2019 at 7:34 PM Peter Bergner wrote: > >>> +#define DRIVER_SELF_SPECS SUBTARGET_DRIVER_SELF_SPECS > >>> + > >>> +#ifndef SUBTARGET_DRIVER_SELF_SPECS > >>> +# define SUBTARGET_DRIVER

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-30 Thread Peter Bergner
On 7/30/19 7:52 AM, Uros Bizjak wrote: > On Thu, Jul 25, 2019 at 7:34 PM Peter Bergner wrote: >>> +#define DRIVER_SELF_SPECS SUBTARGET_DRIVER_SELF_SPECS >>> + >>> +#ifndef SUBTARGET_DRIVER_SELF_SPECS >>> +# define SUBTARGET_DRIVER_SELF_SPECS >>> +#endif > > Shouldn't we swap these two defines, so

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-30 Thread Uros Bizjak
On Thu, Jul 25, 2019 at 7:34 PM Peter Bergner wrote: > > Uros and Jan, > > I should have CC'd you for the i386 portion of the patch. Are you ok with > the i386.h change if Iain's x86 Darwin testing comes out clean? > > Peter > > > On 7/25/19 9:41 AM, Peter Bergner wrote: > > On 7/25/19 2:50 AM, I

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-26 Thread Iain Sandoe
Hi Peter, The patch needs one small amendment to succeed in bootstrap. I applied the amended to i686, x86_64 and powerpc Darwin with no apparent new problems. From the Darwin perspective, the patch is OK with the amendment. (there’s also a note in the text, but that’s just an observation) tha

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-25 Thread Peter Bergner
Uros and Jan, I should have CC'd you for the i386 portion of the patch. Are you ok with the i386.h change if Iain's x86 Darwin testing comes out clean? Peter On 7/25/19 9:41 AM, Peter Bergner wrote: > On 7/25/19 2:50 AM, Iain Sandoe wrote: >> This will break Darwin which has used DRIVER_SELF_S

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-25 Thread Segher Boessenkool
Hi Peter, On Thu, Jul 25, 2019 at 09:41:10AM -0500, Peter Bergner wrote: > On 7/25/19 2:50 AM, Iain Sandoe wrote: > > This will break Darwin which has used DRIVER_SELF_SPECS in config/darwin.h > > since they were introduced (and the equivalent before). > > > > This is because Darwin has driver se

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-25 Thread Iain Sandoe
Hi Peter, > On 25 Jul 2019, at 15:41, Peter Bergner wrote: > > On 7/25/19 2:50 AM, Iain Sandoe wrote: >> This will break Darwin which has used DRIVER_SELF_SPECS in config/darwin.h >> since they were introduced (and the equivalent before). >> >> This is because Darwin has driver self-specs commo

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-25 Thread Peter Bergner
On 7/25/19 2:50 AM, Iain Sandoe wrote: > This will break Darwin which has used DRIVER_SELF_SPECS in config/darwin.h > since they were introduced (and the equivalent before). > > This is because Darwin has driver self-specs common to the PPC and X86 ports. > > If this change is seen the way to go,

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-25 Thread Iain Sandoe
Hi Peter, > On 25 Jul 2019, at 04:30, Peter Bergner wrote: > > The -mdejagnu-cpu= option was added as a way for a test case to ensure a > particular -mcpu= option is used to compile the test, regardless of whether > the user attempts to override it (purposely or accidentally) via RUNTESTFLAGS. >