Re: [PATCH, rs6000] Add additional checks when identifying load/store instructions

2021-08-06 Thread Pat Haugen via Gcc-patches
On 8/6/21 11:05 AM, Segher Boessenkool wrote: > On Fri, Aug 06, 2021 at 10:29:40AM -0500, Pat Haugen wrote: >> On 8/6/21 10:02 AM, Segher Boessenkool wrote: - if (GET_CODE (pat) == SET) + if (GET_CODE (pat) == SET && REG_P (SET_DEST (pat))) return find_mem_ref (SET_SRC (pat),

Re: [PATCH, rs6000] Add additional checks when identifying load/store instructions

2021-08-06 Thread Segher Boessenkool
On Fri, Aug 06, 2021 at 10:29:40AM -0500, Pat Haugen wrote: > On 8/6/21 10:02 AM, Segher Boessenkool wrote: > >> - if (GET_CODE (pat) == SET) > >> + if (GET_CODE (pat) == SET && REG_P (SET_DEST (pat))) > >> return find_mem_ref (SET_SRC (pat), load_mem); > > > > So this now falls through if

Re: [PATCH, rs6000] Add additional checks when identifying load/store instructions

2021-08-06 Thread Pat Haugen via Gcc-patches
On 8/6/21 10:02 AM, Segher Boessenkool wrote: > On Fri, Aug 06, 2021 at 09:47:40AM -0500, Pat Haugen wrote: >> Add additional checks to verify destination[source] of a load[store] >> instruction is a register. > >> * config/rs6000/rs6000.c: (is_load_insn1): Verify destination is a >> reg

Re: [PATCH, rs6000] Add additional checks when identifying load/store instructions

2021-08-06 Thread Segher Boessenkool
On Fri, Aug 06, 2021 at 09:47:40AM -0500, Pat Haugen wrote: > Add additional checks to verify destination[source] of a load[store] > instruction is a register. > * config/rs6000/rs6000.c: (is_load_insn1): Verify destination is a > register. No colon before " (". > --- a/gcc/config/rs