On Tue, Apr 30, 2013 at 1:09 PM, Bruce Korb wrote:
> By analogy, I'd prefer the EOF version there, too. But ultimately,
> it works and is not exactly illegible, so I have no serious objection
> to the fix. It would be nice if it were combinable, but doing so is
> tricky. I'm guessing that the
Hi,
On Tue, Apr 30, 2013 at 9:42 AM, David Edelsohn wrote:
> I coped c_fix_arg from openbsd_null_definition fix. I don't know if
> two different formats for similar fixes would be confusing, but I do
> not have a problem using the EOF version.
I haven't reviewed all patches and I don't always ra
On Tue, Apr 30, 2013 at 11:28 AM, Bruce Korb wrote:
> Hi David,
>
> Looks good to me, but for a small nit:
> Unless there is some reason you want to emphasize tabs with the "\t" escapes.
> I think the "here string" is easier to read.
I coped c_fix_arg from openbsd_null_definition fix. I don't kn
Hi David,
Looks good to me, but for a small nit:
On Tue, Apr 30, 2013 at 7:40 AM, David Edelsohn wrote:
> +c_fix_arg = "#ifndef NULL\n"
> + "#ifdef __cplusplus\n"
> + "#ifdef __GNUG__\n"
> + "#define NULL\t__null\n"
> + "#else\t /* ! __
