RE: [PATCH, RFC] LRA subreg handling

2015-01-26 Thread Robert Suchanek
> > Here we do have a hard register, but it isn't valid to form the subreg > > on that hard register. Reload had to cope with that case too. > > > > Since the subreg on the original hard register is invalid, we can't use > > it to decide whether the intention was to write to only a part of the > >

RE: [PATCH, RFC] LRA subreg handling

2015-01-25 Thread Matthew Fortune
Richard Sandiford writes: > Jeff Law writes: > > On 01/15/15 03:13, Robert Suchanek wrote: > >>> Robert, can you look at reload.c::reload_inner_reg_of_subreg and > >>> verify that the comment just before its return statement is > >>> effectively the situation you're in. > >>> > >>> There are cert

Re: [PATCH, RFC] LRA subreg handling

2015-01-24 Thread Richard Sandiford
Jeff Law writes: > On 01/15/15 03:13, Robert Suchanek wrote: >>> Robert, can you look at reload.c::reload_inner_reg_of_subreg and verify >>> that the comment just before its return statement is effectively the >>> situation you're in. >>> >>> There are certainly cases where a SUBREG needs to be tr

RE: [PATCH, RFC] LRA subreg handling

2015-01-16 Thread Matthew Fortune
Jeff Law writes: > On 01/15/15 03:13, Robert Suchanek wrote: > >> Robert, can you look at reload.c::reload_inner_reg_of_subreg and > >> verify that the comment just before its return statement is > >> effectively the situation you're in. > >> > >> There are certainly cases where a SUBREG needs to

RE: [PATCH, RFC] LRA subreg handling

2015-01-16 Thread Robert Suchanek
> The differences (hard vs pseudo regs) are primarily an implementation > detail. I was really looking to see if there was existing code which > would turn an output reload into an in-out reload for these subregs. > > The in-out nature of certain subregs is something I've personally > stumbled ov

Re: [PATCH, RFC] LRA subreg handling

2015-01-15 Thread Jeff Law
On 01/15/15 03:13, Robert Suchanek wrote: Robert, can you look at reload.c::reload_inner_reg_of_subreg and verify that the comment just before its return statement is effectively the situation you're in. There are certainly cases where a SUBREG needs to be treated as an in-out operand. We walke

Re: [PATCH, RFC] LRA subreg handling

2015-01-15 Thread Vladimir Makarov
On 14/01/15 02:20 PM, Robert Suchanek wrote: > Hi Vladimir, > > An issue has been identified with LRA when running CPU2006 h264ref benchmark. > > I'll try to describe what the issue is and a fix applied as it is very > difficult to reproduce it and it is next to impossible to create a narrowed > te

RE: [PATCH, RFC] LRA subreg handling

2015-01-15 Thread Robert Suchanek
> Robert, can you look at reload.c::reload_inner_reg_of_subreg and verify > that the comment just before its return statement is effectively the > situation you're in. > > There are certainly cases where a SUBREG needs to be treated as an > in-out operand. We walked through them eons ago when we

Re: [PATCH, RFC] LRA subreg handling

2015-01-14 Thread Jeff Law
On 01/14/15 12:20, Robert Suchanek wrote: Hi Vladimir, An issue has been identified with LRA when running CPU2006 h264ref benchmark. I'll try to describe what the issue is and a fix applied as it is very difficult to reproduce it and it is next to impossible to create a narrowed testcase on top