Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-24 Thread Richard Biener
On Thu, Sep 24, 2015 at 4:07 PM, Ilya Enkovich wrote: > 2015-09-15 14:01 GMT+03:00 Ilya Enkovich : >> 2015-09-15 13:32 GMT+03:00 Richard Biener : >>> On Tue, Sep 15, 2015 at 11:28 AM, Ilya Enkovich >>> wrote: >>> >>> I see. I wonder why we even call chkp_find_bound_slots if seen_errors(). >> >>

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-24 Thread Ilya Enkovich
2015-09-15 14:01 GMT+03:00 Ilya Enkovich : > 2015-09-15 13:32 GMT+03:00 Richard Biener : >> On Tue, Sep 15, 2015 at 11:28 AM, Ilya Enkovich >> wrote: >> >> I see. I wonder why we even call chkp_find_bound_slots if seen_errors(). > > Even with errors we still gimplify function. Function parameter

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-15 Thread Ilya Enkovich
2015-09-15 13:32 GMT+03:00 Richard Biener : > On Tue, Sep 15, 2015 at 11:28 AM, Ilya Enkovich > wrote: >> 2015-09-13 16:36 GMT+03:00 Richard Biener : >>> On Mon, Sep 7, 2015 at 2:39 PM, Ilya Enkovich >>> wrote: 2015-09-02 15:35 GMT+03:00 Richard Biener : > > DECL_FIELD_BIT_OFFSET s

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-15 Thread Richard Biener
On Tue, Sep 15, 2015 at 11:28 AM, Ilya Enkovich wrote: > 2015-09-13 16:36 GMT+03:00 Richard Biener : >> On Mon, Sep 7, 2015 at 2:39 PM, Ilya Enkovich wrote: >>> 2015-09-02 15:35 GMT+03:00 Richard Biener : DECL_FIELD_BIT_OFFSET should be never NULL. Whoever created that FIELD_DECL

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-15 Thread Ilya Enkovich
2015-09-13 16:36 GMT+03:00 Richard Biener : > On Mon, Sep 7, 2015 at 2:39 PM, Ilya Enkovich wrote: >> 2015-09-02 15:35 GMT+03:00 Richard Biener : >>> >>> DECL_FIELD_BIT_OFFSET should be never NULL. Whoever created that >>> FIELD_DECL created an invalid one. >>> >>> Richard. >>> >> >> layout_class

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-13 Thread Richard Biener
On Mon, Sep 7, 2015 at 2:39 PM, Ilya Enkovich wrote: > 2015-09-02 15:35 GMT+03:00 Richard Biener : >> >> DECL_FIELD_BIT_OFFSET should be never NULL. Whoever created that >> FIELD_DECL created an invalid one. >> >> Richard. >> > > layout_class_type doesn't place fields with no type Err - that's b

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-07 Thread Ilya Enkovich
2015-09-02 15:35 GMT+03:00 Richard Biener : > > DECL_FIELD_BIT_OFFSET should be never NULL. Whoever created that > FIELD_DECL created an invalid one. > > Richard. > layout_class_type doesn't place fields with no type and thus we have nothing for DECL_FIELD_BIT_OFFSET. We still continue compilatio

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-02 Thread Richard Biener
On Wed, Sep 2, 2015 at 2:51 PM, Ilya Enkovich wrote: > 2015-09-02 15:35 GMT+03:00 Richard Biener : >> On Tue, Sep 1, 2015 at 5:03 PM, Ilya Enkovich wrote: >>> Hi, >>> >>> This fixes an ICE by adding a NULL check. Bootstrapped and regtested for >>> x86_64-unknown-linux-gnu. Applied to trunk. D

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-02 Thread Ilya Enkovich
2015-09-02 15:35 GMT+03:00 Richard Biener : > On Tue, Sep 1, 2015 at 5:03 PM, Ilya Enkovich wrote: >> Hi, >> >> This fixes an ICE by adding a NULL check. Bootstrapped and regtested for >> x86_64-unknown-linux-gnu. Applied to trunk. Does this need to be ported to >> gcc-5-branch? >> >> Thanks,

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-02 Thread Richard Biener
On Tue, Sep 1, 2015 at 5:03 PM, Ilya Enkovich wrote: > Hi, > > This fixes an ICE by adding a NULL check. Bootstrapped and regtested for > x86_64-unknown-linux-gnu. Applied to trunk. Does this need to be ported to > gcc-5-branch? > > Thanks, > Ilya > -- > gcc/ > > 2015-09-01 Ilya Enkovich >