Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-18 Thread Martin Jambor
Hi, On Wed, Jan 16, 2013 at 10:24:10PM +0100, Jan Hubicka wrote: > > On Wed, Jan 16, 2013 at 01:44:20PM +0100, Jan Hubicka wrote: > > > > Perhaps could you first change cgraph_non_local_node_p_1 and try to > > > > check some code > > > > if codegen differs significantly? It should not at all. > >

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-18 Thread Martin Jambor
Hi, On Wed, Jan 16, 2013 at 10:24:10PM +0100, Jan Hubicka wrote: > > On Wed, Jan 16, 2013 at 01:44:20PM +0100, Jan Hubicka wrote: > > > > Perhaps could you first change cgraph_non_local_node_p_1 and try to > > > > check some code > > > > if codegen differs significantly? It should not at all. > >

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-16 Thread Jan Hubicka
> On Wed, Jan 16, 2013 at 01:44:20PM +0100, Jan Hubicka wrote: > > > Perhaps could you first change cgraph_non_local_node_p_1 and try to check > > > some code > > > if codegen differs significantly? It should not at all. > > > ipa-cp is the sole user of this flag in IPA passes, so you should know

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-16 Thread Martin Jambor
On Wed, Jan 16, 2013 at 01:44:20PM +0100, Jan Hubicka wrote: > > Perhaps could you first change cgraph_non_local_node_p_1 and try to check > > some code > > if codegen differs significantly? It should not at all. > > ipa-cp is the sole user of this flag in IPA passes, so you should know what > >

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-16 Thread Jan Hubicka
> Perhaps could you first change cgraph_non_local_node_p_1 and try to check > some code > if codegen differs significantly? It should not at all. > ipa-cp is the sole user of this flag in IPA passes, so you should know what > it does. Thinking deeper of ipa-cp and local virtuals, I think this is

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-16 Thread Jan Hubicka
> On Wed, Jan 16, 2013 at 11:01 AM, Martin Jambor wrote: > > Hi, > > > > PR 55264 is caused by cgraph machinery thinking it knows all calls to > > a virtual method when that is actually not true. As discussed with > > Honza, prior to inlining, we should not assume some virtual functions > > (name

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-16 Thread Richard Biener
On Wed, Jan 16, 2013 at 11:01 AM, Martin Jambor wrote: > Hi, > > PR 55264 is caused by cgraph machinery thinking it knows all calls to > a virtual method when that is actually not true. As discussed with > Honza, prior to inlining, we should not assume some virtual functions > (namely those that