Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2019-02-19 Thread Thomas Schwinge
Hi Chung-Lin! On Tue, 22 Jan 2019 13:16:37 +0100, I wrote: > On Mon, 14 Jan 2019 21:56:05 +0800, Chung-Lin Tang > wrote: > > this version of the wait-clause-with-no-args patch revises the following: > Thanks. > > > Hope this is now okay for trunk when appropriate. > > Given that this is a wro

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2019-01-22 Thread Thomas Schwinge
Hi Chung-Lin! On Mon, 14 Jan 2019 21:56:05 +0800, Chung-Lin Tang wrote: > this version of the wait-clause-with-no-args patch revises the following: > > (1) The way the Fortran FE parts are implemented, which essentially is your > code. > (I'll reflect that in the final ChangeLog) > > (2) Inst

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2019-01-14 Thread Chung-Lin Tang
Hi Thomas, this version of the wait-clause-with-no-args patch revises the following: (1) The way the Fortran FE parts are implemented, which essentially is your code. (I'll reflect that in the final ChangeLog) (2) Instead of trying to encode ACC_ASYNC_NOVAL into num_waits, I've followed your su

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-12-17 Thread Thomas Schwinge
Hi Chung-Lin! On Tue, 27 Nov 2018 22:41:54 +0800, Chung-Lin Tang wrote: > On 2018/11/8 3:13 AM, Thomas Schwinge wrote: > > Now, why do we need the following changes, in this rather "convoluted" > > form: > |--- gcc/omp-expand.c (revision 263981) |+++ gcc/omp-expand.c (workin

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-11-30 Thread Thomas Schwinge
Hi Chung-Lin! On Wed, 07 Nov 2018 20:13:29 +0100, Thomas Schwinge wrote: > On Thu, 30 Aug 2018 21:27:22 +0800, Chung-Lin Tang > wrote: > > Hi, this patch properly handles OpenACC 'wait' clauses without arguments, > > making it an equivalent of "wait all". > > (current trunk basically discard

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-11-27 Thread Chung-Lin Tang
On 2018/11/8 3:13 AM, Thomas Schwinge wrote: NACK. Instead let's do the following, similar to C, C++, and also similar to Fortran's OpenACC async clause handling without explicit async-argument: --- gcc/fortran/openmp.c +++ gcc/fortran/openmp.c @@ -1885,7 +1885,19 @@ gfc_match_omp_clauses (gfc_

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 08:13:29PM +0100, Thomas Schwinge wrote: > Isn't that sufficient for the ABI compatibility that we promise, which is > (unless I'm confused now?) that old (existing) executables continue to > run correctly when dynamically linking against a new libgomp. Or do we > also have

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-11-07 Thread Thomas Schwinge
Hi Chung-Lin! On Thu, 30 Aug 2018 21:27:22 +0800, Chung-Lin Tang wrote: > Hi, this patch properly handles OpenACC 'wait' clauses without arguments, > making it an equivalent of "wait all". Thanks! > (current trunk basically discards and ignores such argument-less wait > clauses) Bugs should

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-10-02 Thread Chung-Lin Tang
Ping (adding Thomas to CC as OpenACC maintainer) On 2018/8/30 9:27 PM, Chung-Lin Tang wrote: Hi, this patch properly handles OpenACC 'wait' clauses without arguments, making it an equivalent of "wait all". (current trunk basically discards and ignores such argument-less wait clauses)  This add