Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-25 Thread Andrew Pinski
On Sat, Aug 25, 2012 at 8:52 AM, Sandra Loosemore wrote: > On 08/24/2012 11:46 PM, Richard Sandiford wrote: >> >> Andrew Pinski writes: >>> >>> On Fri, Aug 24, 2012 at 10:08 PM, Andrew Pinski >>> wrote: On Wed, Aug 22, 2012 at 7:15 PM, Sandra Loosemore wrote: > > On 08/21

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-25 Thread Sandra Loosemore
On 08/24/2012 11:46 PM, Richard Sandiford wrote: Andrew Pinski writes: On Fri, Aug 24, 2012 at 10:08 PM, Andrew Pinski wrote: On Wed, Aug 22, 2012 at 7:15 PM, Sandra Loosemore wrote: On 08/21/2012 02:23 PM, Richard Sandiford wrote: Would be nice to add a compile test for -mabi=64 just t

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-24 Thread Andrew Pinski
On Fri, Aug 24, 2012 at 10:46 PM, Richard Sandiford wrote: > Andrew Pinski writes: >> On Fri, Aug 24, 2012 at 10:08 PM, Andrew Pinski wrote: >>> On Wed, Aug 22, 2012 at 7:15 PM, Sandra Loosemore >>> wrote: On 08/21/2012 02:23 PM, Richard Sandiford wrote: > > > Would be nice to

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-24 Thread Richard Sandiford
Andrew Pinski writes: > On Fri, Aug 24, 2012 at 10:08 PM, Andrew Pinski wrote: >> On Wed, Aug 22, 2012 at 7:15 PM, Sandra Loosemore >> wrote: >>> On 08/21/2012 02:23 PM, Richard Sandiford wrote: Would be nice to add a compile test for -mabi=64 just to make sure that Pmode ==

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-24 Thread Andrew Pinski
On Fri, Aug 24, 2012 at 10:08 PM, Andrew Pinski wrote: > On Wed, Aug 22, 2012 at 7:15 PM, Sandra Loosemore > wrote: >> On 08/21/2012 02:23 PM, Richard Sandiford wrote: >>> >>> >>> Would be nice to add a compile test for -mabi=64 just to make sure >>> that Pmode == DImode works. A copy of an exis

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-24 Thread Andrew Pinski
On Wed, Aug 22, 2012 at 7:15 PM, Sandra Loosemore wrote: > On 08/21/2012 02:23 PM, Richard Sandiford wrote: >> >> >> Would be nice to add a compile test for -mabi=64 just to make sure >> that Pmode == DImode works. A copy of an existing test like >> code-readable-1.c would be fine. > > > I'm havi

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-23 Thread Richard Sandiford
Sandra Loosemore writes: > On 08/21/2012 02:23 PM, Richard Sandiford wrote: >> >> Would be nice to add a compile test for -mabi=64 just to make sure >> that Pmode == DImode works. A copy of an existing test like >> code-readable-1.c would be fine. > > I'm having problems with this part -- it seem

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-22 Thread Richard Sandiford
Sandra Loosemore writes: > 2012-08-22 Julian Brown > Sandra Loosemore > > gcc/ > * config/mips/mips.md > (UNSPEC_CASESI_DISPATCH): New. > (MIPS16_T_REGNUM): New constant. > (tablejump): Don't use for MIPS16_SHORT_JUMP_TABLES. > (casesi): New. >

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-22 Thread Sandra Loosemore
On 08/21/2012 02:23 PM, Richard Sandiford wrote: Would be nice to add a compile test for -mabi=64 just to make sure that Pmode == DImode works. A copy of an existing test like code-readable-1.c would be fine. I'm having problems with this part -- it seems like every combination of options wi

Re: [PATCH, MIPS] fix MIPS16 jump table overflow

2012-08-21 Thread Richard Sandiford
Sandra Loosemore writes: > In config/mips/mips.h, there is presently this comment: > > /* ??? 16-bit offsets can overflow in large functions. */ > #define TARGET_MIPS16_SHORT_JUMP_TABLES TARGET_MIPS16_TEXT_LOADS > > A while ago we had a bug report where a big switch statement did, in > fact, ove