Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-06 Thread Ilya Enkovich
2015-04-03 20:09 GMT+03:00 Jan Hubicka : >> >> That is the reason for fixing chains in privatize_symbol_name. > > OK, so with your proposed patch you produce the links during lto-stream-in > but because the links may be wrong due to multiple different symbol sharing > same > assembler name you rel

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-03 Thread Jan Hubicka
> > I think this will lead to wrong code. At this time, we may have multple > > declarations sharing single assembler name (and thus > > IDENTIFIER_TRANSPARENT_ALIAS link). Think of case where one unit defines > > static > > function and other global function of the same name. We may end up renami

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-03 Thread Ilya Enkovich
2015-04-02 21:48 GMT+03:00 Jan Hubicka : >> On 03/20/2015 02:20 AM, Ilya Enkovich wrote: >> >Hi, >> > >> >Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS >> >bit. We always expect it for instrumentation clones, thus restore it >> >input_cgraph_1. Bootstrapped and tested

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-02 Thread Jeff Law
On 04/02/2015 12:48 PM, Jan Hubicka wrote: On 03/20/2015 02:20 AM, Ilya Enkovich wrote: Hi, Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS bit. We always expect it for instrumentation clones, thus restore it input_cgraph_1. Bootstrapped and tested on x86_64-unknown

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-02 Thread Jan Hubicka
> On 03/20/2015 02:20 AM, Ilya Enkovich wrote: > >Hi, > > > >Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS > >bit. We always expect it for instrumentation clones, thus restore it > >input_cgraph_1. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK > >for trunk

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-02 Thread Jeff Law
On 03/20/2015 02:20 AM, Ilya Enkovich wrote: Hi, Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS bit. We always expect it for instrumentation clones, thus restore it input_cgraph_1. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya --

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-02 Thread Ilya Enkovich
Ping. This patch doesn't affect not instrumented code. Thanks, Ilya 2015-03-20 11:20 GMT+03:00 Ilya Enkovich : > Hi, > > Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS bit. > We always expect it for instrumentation clones, thus restore it > input_cgraph_1. Bootstrapp