Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-13 Thread Eric Botcazou
> I poked at this a little and noticed a difference between the x86_64 > support and the RISC-V support. The RISC-V C language port has char > as unsigned by default. The x86_64 port has char signed by default. > If I add a -fsigned-char option, then the testcase works as expected > for RISC-V.

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-12 Thread Pierre-Marie de Rodat
On 07/13/2018 01:57 AM, Jim Wilson wrote: I poked at this a little and noticed a difference between the x86_64 support and the RISC-V support. The RISC-V C language port has char as unsigned by default. The x86_64 port has char signed by default. If I add a -fsigned-char option, then the testca

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-12 Thread Jim Wilson
On Thu, Jul 12, 2018 at 8:56 AM, Pierre-Marie de Rodat wrote: > I don’t have much more to say than debug11.adb’s comment ;-) > >> This testcase checks that in the DWARF description of the variant type >> below, the C discriminant is properly described as unsigned, hence the >> 0x5a >> ('Z') and 0x

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-12 Thread Pierre-Marie de Rodat
On 07/08/2018 12:35 AM, Eric Botcazou wrote: I haven't tried looking at the failures yet, and might not spend much more time on this. Two of them are debug related, and debug support is a work in progress. I need to finish the native riscv64-linux support before we can do anything useful there,

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-07 Thread Eric Botcazou
> I haven't tried looking at the failures yet, and might not spend much > more time on this. Two of them are debug related, and debug support > is a work in progress. I need to finish the native riscv64-linux > support before we can do anything useful there, and I'd like to get > back to working

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-07 Thread Jim Wilson
On Sat, Jul 7, 2018 at 9:41 AM, Eric Botcazou wrote: > You're welcome. Are the 4 remaining failures related to stack checking? FAIL: gnat.dg/debug11.adb scan-assembler-times 0x5a.*DW_AT_discr_list 1 FAIL: gnat.dg/debug11.adb scan-assembler-times 0x80.*DW_AT_discr_list 1 FAIL: gnat.dg/trampoline4

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-07 Thread Eric Botcazou
> I tried adding the missing definition. I now get > > === acats Summary === > # of expected passes2320 > # of unexpected failures0 > > === gnat Summary === > > # of expected passes2779 > # of unexpected failures4 > # of ex

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-07 Thread Arnaud Charlet
> I tried adding the missing definition. I now get > > === acats Summary === > # of expected passes2320 > # of unexpected failures0 > > === gnat Summary === > > # of expected passes2779 > # of unexpected failures4 > # of ex

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-07 Thread Jim Wilson
On Fri, Jul 6, 2018 at 12:55 AM, Eric Botcazou wrote: >> Ada doesn't use trampolines if you define... >> >> > + Always_Compatible_Rep : constant Boolean := False; >> >> ...this to False. > > And also define TARGET_CUSTOM_FUNCTION_DESCRIPTORS for the architecture. I tried adding the missing

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Jim Wilson
On Fri, Jul 6, 2018 at 12:16 AM, Arnaud Charlet wrote: >> Ada is a low priority side project for me, so if you want non-trivial changes >> it may be a while before I can get to them. There is a lot of other stuff >> higher on my priority list at the moment, such as getting native gdb support >> w

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Eric Botcazou
> Ada doesn't use trampolines if you define... > > > + Always_Compatible_Rep : constant Boolean := False; > > ...this to False. And also define TARGET_CUSTOM_FUNCTION_DESCRIPTORS for the architecture. -- Eric Botcazou

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Eric Botcazou
> The result is good enough to bootstrap natively and seems to give reasonable > native testsuite results for a first attempt. The machine I'm running on > has broken icache flushing, so trampolines won't work, and I suspect that > is causing a lot of the testsuite failures. Ada doesn't use tramp

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Arnaud Charlet
> Ada is a low priority side project for me, so if you want non-trivial changes > it may be a while before I can get to them. There is a lot of other stuff > higher on my priority list at the moment, such as getting native gdb support > working. If this isn't OK as is, then I'm willing to put wor