Re: [PATCH, ARM] Fix ABI for double-precision helpers on single-float-only CPUs

2011-06-13 Thread Ramana Radhakrishnan
> > I'm re-testing the attached version. Shouldn't this be backported to release branches - specifically 4.6 (and 4.5 since this is where TARGET_VFP_SINGLE was introduced) ? cheers Ramana

Re: [PATCH, ARM] Fix ABI for double-precision helpers on single-float-only CPUs

2011-06-06 Thread Richard Earnshaw
On 06/03/11 18:41, Julian Brown wrote: On Thu, 02 Jun 2011 16:35:01 +0100 Richard Earnshaw wrote: I see Paul has already approved this, but I've just spotted one potential problem that might cause latent bugs sometime in the future. The code to register the libcalls is only run once, the

Re: [PATCH, ARM] Fix ABI for double-precision helpers on single-float-only CPUs

2011-06-03 Thread Julian Brown
On Thu, 02 Jun 2011 16:35:01 +0100 Richard Earnshaw wrote: > I see Paul has already approved this, but I've just spotted one > potential problem that might cause latent bugs sometime in the future. > > The code to register the libcalls is only run once, the first time we > try to look up a libca

Re: [PATCH, ARM] Fix ABI for double-precision helpers on single-float-only CPUs

2011-06-02 Thread Richard Earnshaw
On Fri, 2011-05-27 at 17:32 +0100, Julian Brown wrote: > The helper functions used to implement double-precision arithmetic on > ARM processors that only support single-precision arithmetic in hardware > should use the soft-float ABI (i.e. passing and returning floating-point > arguments in core r

Re: [PATCH, ARM] Fix ABI for double-precision helpers on single-float-only CPUs

2011-06-02 Thread Paul Brook
> gcc/ > * config/arm/arm.c (arm_libcall_uses_aapcs_base) > (arm_init_cumulative_args): Use correct ABI for double-precision > helper functions in hard-float mode if only single-precision > arithmetic is supported in hardware. Ok, though I'd add a bit more explanation to the co