Re: [PATCH, 3/5] Handle original loop tree in expand_omp_for_generic

2015-10-13 Thread Thomas Schwinge
Hi Tom! On Mon, 12 Oct 2015 18:56:29 +0200, Tom de Vries wrote: > Handle original loop tree in expand_omp_for_generic > > 2015-09-12 Tom de Vries > > PR tree-optimization/67476 > * omp-low.c (expand_omp_for_generic): Handle original loop tree. Working on a merge from trunk into

Re: [PATCH, 3/5] Handle original loop tree in expand_omp_for_generic

2015-10-12 Thread Bernd Schmidt
Does this version look better? In terms of clarity, yes. Only one thing: + if (/* If we already have a loop struct for the original loop, don't +allocate a new one. */ + !orig_loop_has_loop_struct Don't really like the formatting with this comment. I'd pull it in fr

Re: [PATCH, 3/5] Handle original loop tree in expand_omp_for_generic

2015-10-12 Thread Tom de Vries
On 12/10/15 16:11, Bernd Schmidt wrote: On 10/10/2015 01:58 PM, Tom de Vries wrote: Handle original loop tree in expand_omp_for_generic 2015-09-10 Tom de Vries PR tree-optimization/67476 * omp-low.c (expand_omp_for_generic): Handle original loop tree. This one I find slightly confu

Re: [PATCH, 3/5] Handle original loop tree in expand_omp_for_generic

2015-10-12 Thread Bernd Schmidt
On 10/10/2015 01:58 PM, Tom de Vries wrote: Handle original loop tree in expand_omp_for_generic 2015-09-10 Tom de Vries PR tree-optimization/67476 * omp-low.c (expand_omp_for_generic): Handle original loop tree. This one I find slightly confusing. - add_bb_to_loop (l2