Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi! On 2018-05-25T13:01:58-0700, Cesar Philippidis wrote: > This patch updates GCC's to support OpenACC 2.5's data clause semantics. Per "OpenACC 2.5: 'acc_delete' etc. on non-present data is a no-op", which this patch didn't address. I wanted to delay fixing this

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

Hi! On 2018-06-19T10:01:20-0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in libgomp. > --- a/libgomp/libgomp.h > +++ b/libgomp/libgomp.h > @@ -853,6 +853,8 @@ struct splay_tree_key_s { >uintptr_t tgt_offset; >/* Reference count. */ >uin

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

Hi Jakub! Any comments on my questions, please? On Thu, 02 May 2019 16:03:09 +0200, I wrote: > I'm currently working on other pending OpenACC 'deviceptr' clause patches > from our backlog, and I noticed the following, which I don't understand. > You reviewed and approved this patch, could you ple

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

Hi Jakub! I'm currently working on other pending OpenACC 'deviceptr' clause patches from our backlog, and I noticed the following, which I don't understand. You reviewed and approved this patch, could you please help? On Tue, 19 Jun 2018 10:01:20 -0700, Cesar Philippidis wrote: > --- a/libgomp/

Re: [GCC 9 RM attention] Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi Jakub! On Mon, 29 Apr 2019 12:59:03 +0200, Jakub Jelinek wrote: > On Mon, Apr 29, 2019 at 12:18:15PM +0200, Thomas Schwinge wrote: > > I know it's very late in the GCC 9 release process, but I'm still > > catching up with OpenACC patch review, and just at the end of last week > > I'd noticed t

Re: [GCC 9 RM attention] Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

On Mon, Apr 29, 2019 at 12:18:15PM +0200, Thomas Schwinge wrote: > I know it's very late in the GCC 9 release process, but I'm still > catching up with OpenACC patch review, and just at the end of last week > I'd noticed that this commit (trunk r261813): I'd like to see full patch before consideri

[GCC 9 RM attention] Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi Jakub! I know it's very late in the GCC 9 release process, but I'm still catching up with OpenACC patch review, and just at the end of last week I'd noticed that this commit (trunk r261813): On Fri, 25 May 2018 13:01:58 -0700, Cesar Philippidis wrote: > This patch updates GCC's to support Op

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi! On Fri, 14 Dec 2018 22:24:47 +0100, I wrote: > On Fri, 25 May 2018 13:01:58 -0700, Cesar Philippidis > wrote: > > This patch updates GCC's to support OpenACC 2.5's data clause semantics. > > In OpenACC 2.5, copy, copyin and copyout all behave like their > > present_or_* counterparts in Ope

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi! On Fri, 25 May 2018 13:01:58 -0700, Cesar Philippidis wrote: > This patch updates GCC's to support OpenACC 2.5's data clause semantics. > In OpenACC 2.5, copy, copyin and copyout all behave like their > present_or_* counterparts in OpenACC 2.0. The patch also adds support > for the new fi

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

On 06/20/2018 10:03 AM, Jakub Jelinek wrote: > On Wed, Jun 20, 2018 at 09:59:29AM -0700, Cesar Philippidis wrote: >> If it means anything, we have a significant async change that removes >> the async_refcount field in that struct. > > Wasn't async_refcount removed 2 years ago? You're right. I wa

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

On Wed, Jun 20, 2018 at 09:59:29AM -0700, Cesar Philippidis wrote: > > I'm not entirely happy about this, it grows the structure for not just > > OpenACC, but also OpenMP which will never use it. Are there any fields > > not used by OpenACC? E.g. is link_key used? > > Or could the dynamic refcoun

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

On 06/20/2018 09:45 AM, Jakub Jelinek wrote: > On Tue, Jun 19, 2018 at 10:01:20AM -0700, Cesar Philippidis wrote: >> >From 53ee03231c5e6e4747b4ef01335079a2d4a98480 Mon Sep 17 00:00:00 2001 >> From: Cesar Philippidis >> Date: Tue, 19 Jun 2018 09:33:04 -0700 >> Subject: [PATCH 7/7] runtime changes

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

On Tue, Jun 19, 2018 at 10:01:20AM -0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in libgomp. > > Is it OK for trunk? > 2018-06-19 Chung-Lin Tang > Thomas Schwinge > Cesar Philippidis > > libgomp/ > * libgomp.h (

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - middle end

On Tue, Jun 19, 2018 at 10:00:37AM -0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in the > middle end. > > Is it OK for trunk? > > Cesar > 2018-06-19 Chung-Lin Tang > Thomas Schwinge > Cesar Philippidis > > gcc/c-fami

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - Fortran

On Tue, Jun 19, 2018 at 09:59:57AM -0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in the > Fortran FE. > > Is it OK for trunk? > > Cesar > 2018-06-19 Chung-Lin Tang > Thomas Schwinge > Cesar Philippidis > > gcc/fortra

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - C++

On Tue, Jun 19, 2018 at 09:58:26AM -0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in the C++ FE. > > Is it OK for trunk? > > Cesar > 2018-06-19 Chung-Lin Tang > Thomas Schwinge > Cesar Philippidis > > gcc/cp/ >

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - C

On Tue, Jun 19, 2018 at 09:59:09AM -0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in the C FE. > > Is it OK for trunk? > > Cesar > 2018-06-19 Chung-Lin Tang > Thomas Schwinge > Cesar Philippidis > > gcc/c/ > * c

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime tests

This patch updates the existing OpenACC libgomp runtime tests with the new OpenACC 2.5 data clause semantics. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis libgomp/ * testsuite/libgomp.oacc-c-c++-common/data-already-1.c: Update test case

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - compiler tests

This patch updates the existing OpenACC compiler tests with the new OpenACC 2.5 data clause semantics. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis gcc/testsuite/ * c-c++-common/goacc/declare-1.c: Update test case to utilize OpenACC 2.5

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

This patch implements the OpenACC 2.5 data clause semantics in libgomp. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis libgomp/ * libgomp.h (struct splay_tree_key_s): Add dynamic_refcount member. (gomp_acc_remove_pointer): Update declarati

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - middle end

This patch implements the OpenACC 2.5 data clause semantics in the middle end. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis gcc/c-family/ * c-pragma.h (enum pragma_omp_clause): Add PRAGMA_OACC_CLAUSE_{FINALIZE,IF_PRESENT}. Remove PRAGMA

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - Fortran

This patch implements the OpenACC 2.5 data clause semantics in the Fortran FE. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis gcc/fortran/ * gfortran.h (gfc_omp_clauses): Add unsigned if_present, finalize bitfields. * openmp.c (enum omp_m

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - C

This patch implements the OpenACC 2.5 data clause semantics in the C FE. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis gcc/c/ * c-parser.c (c_parser_omp_clause_name): Add support for finalize and if_present. Make present_or_{copy,copyin,c

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - C++

This patch implements the OpenACC 2.5 data clause semantics in the C++ FE. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis gcc/cp/ * parser.c (cp_parser_omp_clause_name): Add support for finalize and if_present. Make present_or_{copy,copyin

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Ping. To make this patch easier to review, I'll split it into individual patches for each major component in follow up emails. Cesar On 05/25/2018 01:01 PM, Cesar Philippidis wrote: > This patch updates GCC's to support OpenACC 2.5's data clause semantics. > In OpenACC 2.5, copy, copyin and cop