Re: [HSA, PATCH] Enhance dump output

2016-03-21 Thread Martin Liška
On 03/21/2016 06:44 PM, Martin Jambor wrote: ...please remove the added newlines here... >+ if (symbol->m_directive_offset) >+fprintf (f, " /* BRIG offset: %u", symbol->m_directive_offset); ...and I think you are missing an ending "*/" in the string you dump. Sure, fixed.

Re: [HSA, PATCH] Enhance dump output

2016-03-21 Thread Martin Jambor
Hi, On Mon, Mar 21, 2016 at 12:14:19PM +0100, Martin Liska wrote: > Hello. > > Following patch enhances dump output for SBR instructions and > provides a BRIG offset of HSA symbols. The change does not touch any > code generation snippet and I hope it can be installed during the stage4? yes, but