Re: [GOOGLE] replace getline with fgets

2014-07-14 Thread Xinliang David Li
On Mon, Jul 14, 2014 at 2:37 PM, Andrew Pinski wrote: > On Mon, Jul 14, 2014 at 1:40 PM, Dehao Chen wrote: >> This patch replaces getline with fgets so that gcc builts fine in darwin. > > > Why not add getline to libiberty instead? This patch causes a huge stack > usage. The callee is only cal

Re: [GOOGLE] replace getline with fgets

2014-07-14 Thread Andrew Pinski
On Mon, Jul 14, 2014 at 1:40 PM, Dehao Chen wrote: > This patch replaces getline with fgets so that gcc builts fine in darwin. Why not add getline to libiberty instead? This patch causes a huge stack usage. Thanks, Andrew Pinski > > Testing on going, ok for google-4_9 if test passes? > > Than