Re: [GOOGLE] Writes annotation info in elf section.

2014-03-12 Thread Xinliang David Li
Dehao explained that the data needs to merged during link time to give meaningful diagnostics. Ok for google branch. David On Wed, Mar 12, 2014 at 3:55 PM, Xinliang David Li wrote: > Why is it not enough to emit warnings during build time when source > code changes signifcantly? > > David > >

Re: [GOOGLE] Writes annotation info in elf section.

2014-03-12 Thread Xinliang David Li
Why is it not enough to emit warnings during build time when source code changes signifcantly? David On Tue, Mar 11, 2014 at 4:27 PM, Dehao Chen wrote: > During AutoFDO annotation, we want to record the annotation stats into > an elf section, so that we can calculate how much percentage of the >

Re: [GOOGLE] Writes annotation info in elf section.

2014-03-12 Thread Dehao Chen
Thanks Cary for the comments. Patch updated, an also added a tool in contrib/ to dump the profile annotation coverage. Dehao > > > On Wed, Mar 12, 2014 at 9:48 AM, Cary Coutant wrote: >> >> +void autofdo_source_profile::write_annotated_count () const >> +{ >> + switch_to_section (get_section (