Re: [GOOGLE] Fix gcda build info support

2014-09-11 Thread Xinliang David Li
ok. David On Thu, Sep 11, 2014 at 11:49 AM, Teresa Johnson wrote: > On Thu, Sep 11, 2014 at 10:17 AM, Xinliang David Li > wrote: >> Yes, that is what I meant. >> >> David >> >> On Thu, Sep 11, 2014 at 10:09 AM, Teresa Johnson >> wrote: >>> On Wed, Sep 10, 2014 at 3:31 PM, Xinliang David Li

Re: [GOOGLE] Fix gcda build info support

2014-09-11 Thread Teresa Johnson
On Thu, Sep 11, 2014 at 10:17 AM, Xinliang David Li wrote: > Yes, that is what I meant. > > David > > On Thu, Sep 11, 2014 at 10:09 AM, Teresa Johnson wrote: >> On Wed, Sep 10, 2014 at 3:31 PM, Xinliang David Li >> wrote: >>> Can you share the buildinfo reader code with the merger by defininig

Re: [GOOGLE] Fix gcda build info support

2014-09-11 Thread Xinliang David Li
Yes, that is what I meant. David On Thu, Sep 11, 2014 at 10:09 AM, Teresa Johnson wrote: > On Wed, Sep 10, 2014 at 3:31 PM, Xinliang David Li wrote: >> Can you share the buildinfo reader code with the merger by defininig >> some hooks for different callbacks? > > Do you mean the two blobs of co

Re: [GOOGLE] Fix gcda build info support

2014-09-11 Thread Teresa Johnson
On Wed, Sep 10, 2014 at 3:31 PM, Xinliang David Li wrote: > Can you share the buildinfo reader code with the merger by defininig > some hooks for different callbacks? Do you mean the two blobs of code guarded by 'if (tag == GCOV_TAG_BUILD_INFO)' that I added here and the existing one in gcov_exit

Re: [GOOGLE] Fix gcda build info support

2014-09-10 Thread Xinliang David Li
Can you share the buildinfo reader code with the merger by defininig some hooks for different callbacks? David On Wed, Sep 10, 2014 at 10:24 AM, Teresa Johnson wrote: > While porting recent support for a build info section in the gcda from > google/4_8 to 4_9 and doing manual testing, I discover