Re: [Fortran, Patch, PR51815, v3] Fix parsing of substring refs in coarrays.

2024-10-08 Thread Andre Vehreschild
Hi Harald, I agree that the gfc_match_array_ref() is not needed for error recovery or helps anyhow. I therefore removed it. I left the new error message in, because in the case that c = x(:)(2:5) is in a subroutine, like in pr102532.f90, then I get no error. Neither without return MATCH_ERROR nor

Re: [Fortran, Patch, PR51815, v3] Fix parsing of substring refs in coarrays.

2024-10-07 Thread Harald Anlauf
Hi Andre, On 10/7/24 11:04, Andre Vehreschild wrote: Hi Harald, thank you for your input. I still have some small nits to discuss to make everyone happy. Therefore: this seems to go into the right direction - except that I am not a great fan of gfc_error_now, as that tries to paper over defic

Re: [Fortran, Patch, PR51815, v3] Fix parsing of substring refs in coarrays.

2024-10-07 Thread Andre Vehreschild
Hi Harald, thank you for your input. I still have some small nits to discuss to make everyone happy. Therefore: > this seems to go into the right direction - except that I am not a > great fan of gfc_error_now, as that tries to paper over deficiencies > in error recovery. Me either, but when I r