Re: [Diagnostic Patch] don't print column zero

2017-11-20 Thread Nathan Sidwell
On 11/20/2017 05:41 AM, Christophe Lyon wrote: I have just committed (r254949) the attached patch to fix a regression in the arm tests after this was committed (r254691). I hope it's obvious enough. I certainly think so. thanks! nathan -- Nathan Sidwell

Re: [Diagnostic Patch] don't print column zero

2017-11-20 Thread Christophe Lyon
Hi, On 9 November 2017 at 00:25, Jeff Law wrote: > On 11/08/2017 10:36 AM, Nathan Sidwell wrote: >> On 11/02/2017 04:33 PM, Nathan Sidwell wrote: >>> On 10/26/2017 10:34 AM, David Malcolm wrote: [CCing Rainer and Mike for the gcc-dg.exp part] >>> My Tcl skills aren't great, so hopefully

Re: [Diagnostic Patch] don't print column zero

2017-11-08 Thread Jeff Law
On 11/08/2017 10:36 AM, Nathan Sidwell wrote: > On 11/02/2017 04:33 PM, Nathan Sidwell wrote: >> On 10/26/2017 10:34 AM, David Malcolm wrote: >>> [CCing Rainer and Mike for the gcc-dg.exp part] >> >>> My Tcl skills aren't great, so hopefully someone else can review this; >>> CCing Rainer and Mike.

Re: [Diagnostic Patch] don't print column zero

2017-11-08 Thread Nathan Sidwell
On 11/02/2017 04:33 PM, Nathan Sidwell wrote: On 10/26/2017 10:34 AM, David Malcolm wrote: [CCing Rainer and Mike for the gcc-dg.exp part] My Tcl skills aren't great, so hopefully someone else can review this; CCing Rainer and Mike. Ping? https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01911

Re: [Diagnostic Patch] don't print column zero

2017-11-02 Thread Martin Sebor
On 10/26/2017 12:23 PM, Nathan Sidwell wrote: On 10/26/2017 02:12 PM, Eric Gallager wrote: On 10/26/17, Nathan Sidwell wrote: On 10/26/2017 10:34 AM, David Malcolm wrote: Possibly a silly question, but is it OK to have a formatted string call in which some of the arguments aren't consumed?

Re: [Diagnostic Patch] don't print column zero

2017-11-02 Thread Nathan Sidwell
On 10/26/2017 10:34 AM, David Malcolm wrote: [CCing Rainer and Mike for the gcc-dg.exp part] My Tcl skills aren't great, so hopefully someone else can review this; CCing Rainer and Mike. Ping? https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01911.html nathan -- Nathan Sidwell

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Nathan Sidwell
On 10/26/2017 02:12 PM, Eric Gallager wrote: On 10/26/17, Nathan Sidwell wrote: On 10/26/2017 10:34 AM, David Malcolm wrote: Possibly a silly question, but is it OK to have a formatted string call in which some of the arguments aren't consumed? (here "col" is only consumed for the true case,

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Eric Gallager
On 10/26/17, Nathan Sidwell wrote: > On 10/26/2017 10:34 AM, David Malcolm wrote: >> [CCing Rainer and Mike for the gcc-dg.exp part] > >> Alternate idea: could show_column become a tri-state: >>* default: show non-zero columns >>* never: never show columns >>* always: always show a col

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Nathan Sidwell
On 10/26/2017 10:34 AM, David Malcolm wrote: [CCing Rainer and Mike for the gcc-dg.exp part] Alternate idea: could show_column become a tri-state: * default: show non-zero columns * never: never show columns * always: always show a column, printing 0 for the no-column case and then us

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread David Malcolm
[CCing Rainer and Mike for the gcc-dg.exp part] On Thu, 2017-10-26 at 07:33 -0400, Nathan Sidwell wrote: > On the modules branch, I'm starting to add location > information. Line > numbers don't really make sense when reporting errors reading a > binary > file, so I wanted to change the diagnos