Re: [Diagnostic Patch] Clean-up diagnostic facilities in diagnostic.c

2016-06-06 Thread Paolo Carlini
Hi David, On 06/06/2016 22:26, David Malcolm wrote: Thanks, looks like a nice simplification. I see the new prototypes are wrapped in #ifdef ATTRIBUTE_GCC_DIAG. Isn't that redundant? Looking at diagnostic-core.h, isn't it always defined? (perhaps to the empty string) Also the new functions ar

Re: [Diagnostic Patch] Clean-up diagnostic facilities in diagnostic.c

2016-06-06 Thread David Malcolm
On Mon, 2016-06-06 at 10:55 +0200, Paolo Carlini wrote: > Hi, > > yesterday I had the idea of this small clean-up: move the work done > by > emit_diagnostic to a new non-variadic diagnostic_impl and use it to > implement the former and all the various inform, warning, permerror, > etc > (lately