Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-05-06 Thread Marek Polacek
On Sat, May 03, 2014 at 04:51:53PM +0530, Prathamesh Kulkarni wrote: > * c-tree.h (C_ARRAY_PARM): New macro, alias for DECL_LANG_FLAG_2. "New macro." would be enough. > --- gcc/c/c-decl.c(revision 210004) > +++ gcc/c/c-decl.c(working copy) > @@ -4650,6 +4650,8 @@ push_parm_decl (const s

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-05-03 Thread Prathamesh Kulkarni
On Fri, May 2, 2014 at 5:50 AM, Joseph S. Myers wrote: > The following apply to all versions of this patch: > > * New options need documenting in invoke.texi. Added. > > * New options need nonempty help text in c.opt. (It's unfortunate that > the -Wsizeof-pointer-memaccess option immediately abov

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-05-01 Thread Joseph S. Myers
The following apply to all versions of this patch: * New options need documenting in invoke.texi. * New options need nonempty help text in c.opt. (It's unfortunate that the -Wsizeof-pointer-memaccess option immediately above got added without such help text.) * Don't use %s with IDENTIFIER_PO

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Mon, Apr 28, 2014 at 2:13 AM, Andrew Pinski wrote: > On Sun, Apr 27, 2014 at 1:25 PM, Prathamesh Kulkarni > wrote: >> On Mon, Apr 28, 2014 at 1:31 AM, Andrew Pinski wrote: >>> On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni >>> wrote: On Sun, Apr 27, 2014 at 11:22 PM, wrote: >>>

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Andrew Pinski
On Sun, Apr 27, 2014 at 1:25 PM, Prathamesh Kulkarni wrote: > On Mon, Apr 28, 2014 at 1:31 AM, Andrew Pinski wrote: >> On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni >> wrote: >>> On Sun, Apr 27, 2014 at 11:22 PM, wrote: > On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Mon, Apr 28, 2014 at 1:31 AM, Andrew Pinski wrote: > On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni > wrote: >> On Sun, Apr 27, 2014 at 11:22 PM, wrote: >>> >>> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saun

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Andrew Pinski
On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 11:22 PM, wrote: >> >> >>> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni >>> wrote: >>> On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014 at 06:21:20PM +0530,

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Sun, Apr 27, 2014 at 11:22 PM, wrote: > > >> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni >> wrote: >> >>> On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders >>> wrote: On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 5:31 PM, Trevo

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread pinskia
> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni > wrote: > >> On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders >> wrote: >>> On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: >> On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders >> wrote: >> > On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: >> >> Hi, >> >> Shall it a go

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders > wrote: > > On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: > >> Hi, > >> Shall it a good idea to add new warning -Wsizeof-array-argument that > >> war

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: >> Hi, >> Shall it a good idea to add new warning -Wsizeof-array-argument that >> warns when sizeof is applied on parameter declared as an array ? > > Seems reasonable

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: > Hi, > Shall it a good idea to add new warning -Wsizeof-array-argument that > warns when sizeof is applied on parameter declared as an array ? Seems reasonable enough. > Similar to clang's -Wsizeof-array-argument: > http://