Re: [C PATCH] Tidy up pedwarn_c90 (take 2)

2014-09-08 Thread Marek Polacek
On Fri, Aug 29, 2014 at 07:16:55PM +0200, Manuel López-Ibáñez wrote: > On 19 August 2014 00:06, Joseph S. Myers wrote: > > On Tue, 12 Aug 2014, Marek Polacek wrote: > > > >> This then is the version with both issues fixed (and new test). > >> > >> Bootstrapped/regtested on x86_64-linux, ok for tru

Re: [C PATCH] Tidy up pedwarn_c90 (take 2)

2014-08-29 Thread Manuel López-Ibáñez
On 19 August 2014 00:06, Joseph S. Myers wrote: > On Tue, 12 Aug 2014, Marek Polacek wrote: > >> This then is the version with both issues fixed (and new test). >> >> Bootstrapped/regtested on x86_64-linux, ok for trunk? >> >> 2014-08-12 Marek Polacek >> >> gcc/c-family/ >> * c-opts.c (sa

Re: [C PATCH] Tidy up pedwarn_c90 (take 2)

2014-08-18 Thread Joseph S. Myers
On Tue, 12 Aug 2014, Marek Polacek wrote: > This then is the version with both issues fixed (and new test). > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > 2014-08-12 Marek Polacek > > gcc/c-family/ > * c-opts.c (sanitize_cpp_opts): Make warn_long_long be set according >

Re: [C PATCH] Tidy up pedwarn_c90 (take 2)

2014-08-12 Thread Marek Polacek
This then is the version with both issues fixed (and new test). Bootstrapped/regtested on x86_64-linux, ok for trunk? 2014-08-12 Marek Polacek gcc/c-family/ * c-opts.c (sanitize_cpp_opts): Make warn_long_long be set according to warn_c90_c99_compat. * c.opt (Wc90-c99-c

Re: [C PATCH] Tidy up pedwarn_c90

2014-08-11 Thread Marek Polacek
On Mon, Aug 11, 2014 at 08:19:52PM +, Joseph S. Myers wrote: > On Sat, 9 Aug 2014, Marek Polacek wrote: > > > + /* Maybe we want to issue the C90/C99 compat warning, which is more > > + specific than -pedantic. */ > > + if (warn_c90_c99_compat > 0) > > { > >diagnostic_set_i

Re: [C PATCH] Tidy up pedwarn_c90

2014-08-11 Thread Joseph S. Myers
On Sat, 9 Aug 2014, Marek Polacek wrote: > + /* Maybe we want to issue the C90/C99 compat warning, which is more > + specific than -pedantic. */ > + if (warn_c90_c99_compat > 0) > { >diagnostic_set_info (&diagnostic, gmsgid, &ap, location, DK_WARNING); That seems wrong; it mea