Re: [C++ Patch] for c++/52126

2012-02-16 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] for c++/52126

2012-02-16 Thread Fabien Chêne
2012/2/16 Jason Merrill : > On 02/16/2012 01:47 PM, Fabien Chêne wrote: >> >> +  tree binfo_type = TYPE_MAIN_VARIANT (BINFO_TYPE (binfo)); > > > BINFO_TYPE should already be its TYPE_MAIN_VARIANT.  Why isn't it here? > > >> For (2), the lookup was failing because the flag >> BINFO_DEPENDENT_BASE_P

Re: [C++ Patch] for c++/52126

2012-02-16 Thread Jason Merrill
On 02/16/2012 01:47 PM, Fabien Chêne wrote: + tree binfo_type = TYPE_MAIN_VARIANT (BINFO_TYPE (binfo)); BINFO_TYPE should already be its TYPE_MAIN_VARIANT. Why isn't it here? For (2), the lookup was failing because the flag BINFO_DEPENDENT_BASE_P was set. It think it should not be set for t