Re: [C++ Patch] PR 58633 (Take 2)

2013-11-23 Thread Jason Merrill
OK.

Re: [C++ Patch] PR 58633

2013-10-11 Thread Paolo Carlini
On 10/11/2013 03:59 PM, Jason Merrill wrote: On 10/11/2013 06:28 AM, Paolo Carlini wrote: The issue is a regression in 4_7/4_8 too, what should we do in those branches? I'm thinking applying the change to 4_8 too and either not fixing in 4_7 or just reverting the cp_parser_commit_to_tentative_pa

Re: [C++ Patch] PR 58633

2013-10-11 Thread Jason Merrill
On 10/11/2013 06:28 AM, Paolo Carlini wrote: The issue is a regression in 4_7/4_8 too, what should we do in those branches? I'm thinking applying the change to 4_8 too and either not fixing in 4_7 or just reverting the cp_parser_commit_to_tentative_parse change which improved the diagnostic for 4

Re: [C++ Patch] PR 58633

2013-10-11 Thread Paolo Carlini
Hi, On 10/10/2013 08:48 PM, Jason Merrill wrote: I think that committing was important for two primary reasons: 1. We should not have irreversible side-effects while in a tentative state. For example, we shouldn't create a permanent entry in the symbol table, or issue an error message

Re: [C++ Patch] PR 58633

2013-10-10 Thread Jason Merrill
On 10/09/2013 11:14 AM, Mitchell, Mark wrote: Unfortunately, I no longer remember this code well. My recollection -- such as it is -- is just that I couldn't find a case where it was necessary to commit only a single level. You sometimes had to scan an unbounded number of tokens to complete the

Re: [C++ Patch] PR 58633

2013-10-09 Thread Paolo Carlini
Hi, On 10/09/2013 03:56 PM, Jason Merrill wrote: On 10/08/2013 07:03 PM, Paolo Carlini wrote: .. a curiosity: the cp_parser_commit_to_tentative_parse at the end of cp_parser_pseudo_destructor_name, which didn't exist in 4.6.x and we can consider the root of this issue, is also my fault: h

Re: [C++ Patch] PR 58633

2013-10-09 Thread Jason Merrill
On 10/08/2013 07:03 PM, Paolo Carlini wrote: .. a curiosity: the cp_parser_commit_to_tentative_parse at the end of cp_parser_pseudo_destructor_name, which didn't exist in 4.6.x and we can consider the root of this issue, is also my fault: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02246.h

Re: [C++ Patch] PR 58633

2013-10-08 Thread Paolo Carlini
.. a curiosity: the cp_parser_commit_to_tentative_parse at the end of cp_parser_pseudo_destructor_name, which didn't exist in 4.6.x and we can consider the root of this issue, is also my fault: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02246.html From a different angle, I'm happy of the