Re: [C++ Patch] PR 52363

2012-04-24 Thread Jason Merrill
OK, thanks! Jason

Re: [C++ Patch] PR 52363

2012-04-19 Thread Jason Merrill
On 04/19/2012 03:00 PM, Paolo Carlini wrote: Yes, that's life ;) Seriously, if we want to avoid all those having to do with implicit_conversion in one swoop, the eventual patch will be pretty big, should I just go on and on? I think so. Once we start down this road, we should follow it to th

Re: [C++ Patch] PR 52363

2012-04-19 Thread Paolo Carlini
Hi, > On 04/19/2012 08:45 AM, Paolo Carlini wrote: >> @@ -812,7 +816,7 @@ build_list_conv (tree type, tree ctor, int flags) >> { >>conversion *sub >> = implicit_conversion (elttype, TREE_TYPE (val), val, >> - false, flags); >> + false, flags, t

Re: [C++ Patch] PR 52363

2012-04-19 Thread Jason Merrill
On 04/19/2012 08:45 AM, Paolo Carlini wrote: @@ -812,7 +816,7 @@ build_list_conv (tree type, tree ctor, int flags) { conversion *sub = implicit_conversion (elttype, TREE_TYPE (val), val, - false, flags); + false, flag

Re: [C++ Patch] PR 52363

2012-04-19 Thread Paolo Carlini
Hi, On 04/18/2012 08:30 PM, Paolo Carlini wrote: Thus, it seems to me that with above change it's just that we don't have any hope of fixing latent SFINAE bugs in turney called by build_user_type_conversion_1 per the above. And, at this time, we don't have any evidence of such bugs. We've just

Re: [C++ Patch] PR 52363

2012-04-18 Thread Jason Merrill
On 04/18/2012 08:30 PM, Paolo Carlini wrote: Thus, it seems to me that with above change it's just that we don't have any hope of fixing latent SFINAE bugs in turney called by build_user_type_conversion_1 per the above. And, at this time, we don't have any evidence of such bugs. We've just been

Re: [C++ Patch] PR 52363

2012-04-18 Thread Paolo Carlini
On 04/18/2012 09:00 PM, Jason Merrill wrote: On 04/18/2012 01:44 PM, Paolo Carlini wrote: + cand = tourney (candidates, tf_warning_or_error); This seems unlikely to do the right thing; we can get here in both SFINAE and non-SFINAE situations. In build_user_type_conversion_1 I think we can

Re: [C++ Patch] PR 52363

2012-04-18 Thread Paolo Carlini
Hi again, Thus, if I don't ear from you, I'm probably going to add complain to build_user_type_conversion_1, hopefully I can manage, I remember that earlier today I tried and was dragging in a lot of changes... The below adds complain to build_user_type_conversion_1 and build_user_type_conversi

Re: [C++ Patch] PR 52363

2012-04-18 Thread Paolo Carlini
Hi On 04/18/2012 01:44 PM, Paolo Carlini wrote: + cand = tourney (candidates, tf_warning_or_error); This seems unlikely to do the right thing; we can get here in both SFINAE and non-SFINAE situations. In build_user_type_conversion_1 I think we can get away with checking LOOKUP_COMPLAIN; fo

Re: [C++ Patch] PR 52363

2012-04-18 Thread Jason Merrill
On 04/18/2012 01:44 PM, Paolo Carlini wrote: + cand = tourney (candidates, tf_warning_or_error); This seems unlikely to do the right thing; we can get here in both SFINAE and non-SFINAE situations. In build_user_type_conversion_1 I think we can get away with checking LOOKUP_COMPLAIN; for p