Re: [C++ Patch] More grokdeclarator locations fixes

2019-08-08 Thread Jason Merrill
On 8/8/19 5:41 AM, Paolo Carlini wrote: Hi, these are all more or less straightforward, exploit the existing infrastructure. Nits: the first change also removes an 'a' in the wording because all the other error messages - a few - mentioning class or namespace don't have it; the fixes using EX

Re: [C++ Patch] More grokdeclarator locations

2019-06-21 Thread Jason Merrill
On 6/13/19 8:12 PM, Paolo Carlini wrote: Hi, should all be rather straightforward but I spent quite a bit of time on the testsuite changes... Tested x86_64-linux, as usual. OK. PS: at some point we should start talking about all the error, error_at, etc, which are *never* exercised by our t

Re: [C++ Patch] More grokdeclarator locations fixes

2019-06-12 Thread Jason Merrill
On 6/10/19 6:36 AM, Paolo Carlini wrote: Hi, this one requires my last patch, uses id_loc in a few additional places in the last part of the function. Most of the changes should be straightforward, I only want to mention the "typedef name may not be a nested-name-specifier" change, where, no