Re: [C++ Patch] Improve start_function and grokmethod locations

2019-08-13 Thread Jason Merrill
On 8/9/19 7:46 AM, Paolo Carlini wrote: + error_at (id_loc, + "typedef may not be a function definition"); We might use the location of the typedef keyword. OK either way. Jason

Re: [C++ Patch] Improve start_function and grokmethod locations

2019-08-09 Thread Paolo Carlini
Hi, On 08/08/19 16:51, Jason Merrill wrote: On 8/6/19 8:28 AM, Paolo Carlini wrote: apparently this is now easy to do, likely because a while ago I made sure that we consistently have meaningful locations for TYPE_DECLs too. (I went through grokdeclarator and confirmed that when the third ar

Re: [C++ Patch] Improve start_function and grokmethod locations

2019-08-08 Thread Jason Merrill
On 8/6/19 8:28 AM, Paolo Carlini wrote: apparently this is now easy to do, likely because a while ago I made sure that we consistently have meaningful locations for TYPE_DECLs too. (I went through grokdeclarator and confirmed that when the third argument is FUNCDEF or MEMFUNCDEF it cannot retu