Re: [C++ PATCH] get_fns cleanups

2017-05-16 Thread Nathan Sidwell
On 05/16/2017 10:50 AM, Jason Merrill wrote: The change to cxx_incomplete_type_diagnostic seems wrong; the member might be a data member. I couldn't get there with a non-overload, but then I couldn't convince myself there was no other path. It's hardly a critical path, so reverted. -- Natha

Re: [C++ PATCH] get_fns cleanups

2017-05-16 Thread Nathan Sidwell
On 05/16/2017 10:50 AM, Jason Merrill wrote: The change to cxx_incomplete_type_diagnostic seems wrong; the member might be a data member. I had convinced myself that at that point it couldn't be. Will take another look though. Anyway, thanks for the review! nathan -- Nathan Sidwell

Re: [C++ PATCH] get_fns cleanups

2017-05-16 Thread Jason Merrill
The change to cxx_incomplete_type_diagnostic seems wrong; the member might be a data member. Jason