Re: [C++ PATCH] Plural forms for count != eltscnt structured binding diagnostics

2017-11-30 Thread Pedro Alves
On 11/30/2017 01:10 PM, Jakub Jelinek wrote: > On Thu, Nov 30, 2017 at 01:33:48PM +0100, Jakub Jelinek wrote: >> On Thu, Nov 30, 2017 at 01:01:58PM +0100, Jakub Jelinek wrote: >>> I just followed: >>> https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html >>> >>> "Abo

Re: [C++ PATCH] Plural forms for count != eltscnt structured binding diagnostics

2017-11-30 Thread Jakub Jelinek
On Thu, Nov 30, 2017 at 01:33:48PM +0100, Jakub Jelinek wrote: > On Thu, Nov 30, 2017 at 01:01:58PM +0100, Jakub Jelinek wrote: > > I just followed: > > https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html > > > > "About larger integer types, such as ‘uintmax_t’ or

Re: [C++ PATCH] Plural forms for count != eltscnt structured binding diagnostics

2017-11-30 Thread Jakub Jelinek
On Thu, Nov 30, 2017 at 01:01:58PM +0100, Jakub Jelinek wrote: > I just followed: > https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html > > "About larger integer types, such as ‘uintmax_t’ or ‘unsigned long long’: > they can be > handled by reducing the value to

Re: [C++ PATCH] Plural forms for count != eltscnt structured binding diagnostics

2017-11-30 Thread Jakub Jelinek
On Thu, Nov 30, 2017 at 06:55:08AM -0500, Nathan Sidwell wrote: > > --- gcc/cp/decl.c.jj2017-11-30 09:44:19.0 +0100 > > +++ gcc/cp/decl.c 2017-11-30 09:57:44.539504854 +0100 > > @@ -7445,11 +7445,18 @@ cp_finish_decomp (tree decl, tree first, > > > + inform_n (loc, eltscnt !=

Re: [C++ PATCH] Plural forms for count != eltscnt structured binding diagnostics

2017-11-30 Thread Nathan Sidwell
On 11/30/2017 04:18 AM, Jakub Jelinek wrote: Here is an incremental patch to deal with that on top of the previously posted patch, ok for trunk if it passes testing? Note, not using inform_n in this !tree_fits_uhwi_p case, because gettext doesn't recommend that for negative values and the other