Re: [C++ PATCH] Fix comment

2017-10-06 Thread Nathan Sidwell
On 10/05/2017 05:25 PM, Jason Merrill wrote: On Wed, Oct 4, 2017 at 11:44 AM, Nathan Sidwell wrote: On 10/04/2017 11:29 AM, Jason Merrill wrote: On Wed, Oct 4, 2017 at 10:12 AM, Nathan Sidwell wrote: Hmm, I think the error is in the behavior, not the comment. :) I wouldn't disagree. F

Re: [C++ PATCH] Fix comment

2017-10-05 Thread Jason Merrill
On Wed, Oct 4, 2017 at 11:44 AM, Nathan Sidwell wrote: > On 10/04/2017 11:29 AM, Jason Merrill wrote: >> On Wed, Oct 4, 2017 at 10:12 AM, Nathan Sidwell wrote: >>> In answering a question about passing non-trivial types through ..., I >>> discovered a misleading comment. It is NOT just like a va

Re: [C++ PATCH] Fix comment

2017-10-04 Thread Nathan Sidwell
On 10/04/2017 11:29 AM, Jason Merrill wrote: On Wed, Oct 4, 2017 at 10:12 AM, Nathan Sidwell wrote: In answering a question about passing non-trivial types through ..., I discovered a misleading comment. It is NOT just like a value parm, because we don't locally copy it. Hmm, I think the err

Re: [C++ PATCH] Fix comment

2017-10-04 Thread Jason Merrill
On Wed, Oct 4, 2017 at 10:12 AM, Nathan Sidwell wrote: > In answering a question about passing non-trivial types through ..., I > discovered a misleading comment. It is NOT just like a value parm, because > we don't locally copy it. Hmm, I think the error is in the behavior, not the comment. :)