Re: [C++] Fix PR bootstrap/81926

2017-09-22 Thread Eric Botcazou
> This looks good. But let's call it debug_type_hash instead. OK with > that change. Thanks. It occured to me that we don't need to look up the type twice when we need to insert it so I have installed the attached patchlet as obvious after boostrapping/regtesting on x86-64/Linux. PR

Re: [C++] Fix PR bootstrap/81926

2017-09-09 Thread Jason Merrill
On Mon, Sep 4, 2017 at 10:08 AM, Eric Botcazou wrote: >> A solution would be to put them into a global GCed pointer-map or vector, >> freeing that at free-lang-data time. > > Here's a version that implements a bona-fide type->offset_type map. > > PR bootstrap/81926 > * cp-objcp-com

Re: [C++] Fix PR bootstrap/81926

2017-09-04 Thread Richard Biener
On Sun, Sep 3, 2017 at 4:15 PM, Eric Botcazou wrote: >> But not types, less using langhooks. > > #0 cp_get_debug_type (type=0x707702a0) > at /home/eric/svn/gcc-7.2.0/gcc/cp/cp-objcp-common.c:142 > #1 0x009f2c86 in gen_type_die_with_usage ( > type=type@entry=0x707702a0, >

Re: [C++] Fix PR bootstrap/81926

2017-09-04 Thread Eric Botcazou
> A solution would be to put them into a global GCed pointer-map or vector, > freeing that at free-lang-data time. Here's a version that implements a bona-fide type->offset_type map. PR bootstrap/81926 * cp-objcp-common.c (struct offset_type_hasher): New class. (offset_ty

Re: [C++] Fix PR bootstrap/81926

2017-09-03 Thread Eric Botcazou
> But not types, less using langhooks. #0 cp_get_debug_type (type=0x707702a0) at /home/eric/svn/gcc-7.2.0/gcc/cp/cp-objcp-common.c:142 #1 0x009f2c86 in gen_type_die_with_usage ( type=type@entry=0x707702a0, context_die=context_die@entry=0x7fffed7e90a0, usage=usag

Re: [C++] Fix PR bootstrap/81926

2017-09-03 Thread Richard Biener
On September 3, 2017 10:05:19 AM GMT+02:00, Eric Botcazou wrote: >> A solution would be to put them into a global GCed pointer-map or >vector, >> freeing that at free-lang-data time. > >The first part sounds good, but not the second part, as >rest_of_handle_final >generates debug info too. But

Re: [C++] Fix PR bootstrap/81926

2017-09-03 Thread Eric Botcazou
> A solution would be to put them into a global GCed pointer-map or vector, > freeing that at free-lang-data time. The first part sounds good, but not the second part, as rest_of_handle_final generates debug info too. -- Eric Botcazou

Re: [C++] Fix PR bootstrap/81926

2017-09-02 Thread Richard Biener
On September 2, 2017 1:01:11 PM GMT+02:00, Eric Botcazou wrote: >Hi, > >this is the bootstrap failure reported for the 7 branch on >SPARC64/Solaris: > >Comparing stages 2 and 3 >Bootstrap comparison failure! >gcc/go/parse.o differs >make[2]: *** [compare] Error 1 > >On Solaris, the bootstrap is u