Re: [BUILDROBOT] MPS430 build problem due to new enum

2016-06-13 Thread Martin Liška
On 06/13/2016 10:46 AM, Jan Hubicka wrote: > Hmm, namespace conflict. I guess renaming enum items to REASON_* should > solve it easily. > Or we can add a namespace. > > Martin, both variants of fix are pre-approved. > Honza OK, I've just installed (r237370) a patch that prefixes all enum values

Re: [BUILDROBOT] MPS430 build problem due to new enum (was: [PATCH 2/2] Add edge predictions pruning)

2016-06-13 Thread Jan Hubicka
> Hi Martin, > > On Thu, 2016-06-09 13:24:10 +0200, Martin Liška wrote: > > On 06/08/2016 02:41 PM, Jan Hubicka wrote: > > > Adding hash for this prupose is bit of an overkill (there are > > > definitly cheaper ways of solving so), but it will hardly affect compile > > > time, so the pathc is OK.

Re: [BUILDROBOT] MPS430 build problem due to new enum

2016-06-13 Thread Martin Liška
On 06/12/2016 01:55 PM, Jan-Benedict Glaw wrote: > The new `NONE' from your enum clashes with a NONE used in a MSP430 > private enum. > > MfG, JBG Hi. Thanks for having heads up, I've been testing following patch. The patch survives with --target=msp430-elf. Ready after it finishes? Thanks, Mar