Re: [ARM] TLS Descriptor support

2011-06-22 Thread Nathan Sidwell
On 06/21/11 18:24, Ramana Radhakrishnan wrote: revalidated with defaults to both gnu and gnu2 style. ok? This is OK . sigh, in backporting the relevant bits, I noticed a problem with the OPTION_DEFAULT_SPECS string, fixed thusly, committed as obvious. And then I noticed I'd failed to commi

Re: [ARM] TLS Descriptor support

2011-06-21 Thread Ramana Radhakrishnan
> revalidated with defaults to both gnu and gnu2 style. ok? This is OK . Ramana > > nathan > -- > Nathan Sidwell > >

Re: [ARM] TLS Descriptor support

2011-06-21 Thread Nathan Sidwell
This patches addresses your comments. I've fixed: * config and option items Joseph pointed out in http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00719.html * md items Ramana pointed out in http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02109.html * option naming and assembly issues Richard pointed

Re: [ARM] TLS Descriptor support

2011-06-07 Thread Richard Earnshaw
On 06/07/11 07:11, Nathan Sidwell wrote: > On 06/06/11 17:27, Richard Earnshaw wrote: > >> Eh? This is backwards. There is blx , but no bl . If the assembler >> gets confused with 'bl r0' then it needs to be fixed urgently. > > Are you requiring the assembler be fixed before this patch can be com

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Nathan Sidwell
On 06/06/11 17:27, Richard Earnshaw wrote: Eh? This is backwards. There is blx , but no bl . If the assembler gets confused with 'bl r0' then it needs to be fixed urgently. Are you requiring the assembler be fixed before this patch can be committed (without the '+'?) nathan -- Nathan Sidwe

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Richard Earnshaw
On 05/10/11 07:49, Nathan Sidwell wrote: This patch implements TLS descriptor support in GCC. TLS descriptors are described at http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt and blessed by ARM, who have reserved the relocation numbers. Binutils and GLIBC patches are already com

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Ramana Radhakrishnan
On 6 June 2011 10:56, Nathan Sidwell wrote: > On 06/06/11 10:53, Ramana Radhakrishnan wrote: >>> >>> If you're asking something else, can you rephrase the question? >> >> Sorry if I wasn't too clear.  My question really should have read "why >> do we have to special case Thumb2" ? The linker shoul

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Nathan Sidwell
On 06/06/11 10:53, Ramana Radhakrishnan wrote: If you're asking something else, can you rephrase the question? Sorry if I wasn't too clear. My question really should have read "why do we have to special case Thumb2" ? The linker should be able to veneer the t-> a calls either through the vene

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Ramana Radhakrishnan
> If you're asking something else, can you rephrase the question? Sorry if I wasn't too clear. My question really should have read "why do we have to special case Thumb2" ? The linker should be able to veneer the t-> a calls either through the veneering sequence (in case of T1 without blx) or con

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Nathan Sidwell
On 06/03/11 23:50, Ramana Radhakrishnan wrote: How are things handled for Thumb1 in case someone builds a routine for Thumb1 which uses tlsdesc ? I went and read the doc and didn't see any difference between T1 and T2 in the specification . Would the linker and everyone else do the right thing o

Re: [ARM] TLS Descriptor support

2011-06-03 Thread Ramana Radhakrishnan
On 31 May 2011 11:03, Nathan Sidwell wrote: > On 05/27/11 01:47, Ramana Radhakrishnan wrote: > >> Could you consider adding a check in the configury to test if a binutils >> version >> of recent vintage is being used when --with-tls=gnu is in ? > > I thought about that and it didn't seem worth it.

Re: [ARM] TLS Descriptor support

2011-05-31 Thread Nathan Sidwell
On 05/27/11 01:47, Ramana Radhakrishnan wrote: Could you consider adding a check in the configury to test if a binutils version of recent vintage is being used when --with-tls=gnu is in ? I thought about that and it didn't seem worth it. We're not autodetecting whether to default to gnu-styl

Re: [ARM] TLS Descriptor support

2011-05-26 Thread Ramana Radhakrishnan
Thanks for this and sorry about the length of time in reviewing this . On 10/05/11 07:49, Nathan Sidwell wrote: This patch implements TLS descriptor support in GCC. TLS descriptors are described at http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt and blessed by ARM, who have reserved

Re: [ARM] TLS Descriptor support

2011-05-26 Thread Nathan Sidwell
On 05/10/11 07:49, Nathan Sidwell wrote: This patch implements TLS descriptor support in GCC. TLS descriptors are described at http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt and blessed by ARM, who have reserved the relocation numbers. http://gcc.gnu.org/ml/gcc-patches/2011-05/msg

Re: [ARM] TLS Descriptor support

2011-05-11 Thread Nathan Sidwell
On 05/10/11 12:36, Joseph S. Myers wrote: thanks for the review. I've addressed these issues, but will wait for arm-specific review before reposting (I presume you want the chance to check the non-mechanical opt-machinery changes) nathan -- Nathan Sidwell

Re: [ARM] TLS Descriptor support

2011-05-10 Thread Joseph S. Myers
On Tue, 10 May 2011, Nathan Sidwell wrote: > +@item -mtls-dialect=@var{dialect} > +@opindex mtls-dialect > +Specify the dialect to use for accessing thread local storage. Two > +dialects are supported - @option{arm} and @option{gnu}. The Use "---" (em dash, unspaced) instead of " - ". > +@opti