Re: [ABSU_EXPR] Add some of the missing patterns in match,pd

2018-07-02 Thread Richard Biener
On Fri, Jun 29, 2018 at 4:38 AM Kugan Vivekanandarajah wrote: > > Hi Marc, > > Thanks for the review. > > On 28 June 2018 at 14:11, Marc Glisse wrote: > > (why is there no mention of ABSU_EXPR in doc/* ?) > > I will fix this in a separate patch. > > > > --- a/gcc/match.pd > > +++ b/gcc/match.pd >

Re: [ABSU_EXPR] Add some of the missing patterns in match,pd

2018-06-28 Thread Kugan Vivekanandarajah
Hi Marc, Thanks for the review. On 28 June 2018 at 14:11, Marc Glisse wrote: > (why is there no mention of ABSU_EXPR in doc/* ?) I will fix this in a separate patch. > > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -571,10 +571,12 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > (copysigns (op @0)

Re: [ABSU_EXPR] Add some of the missing patterns in match,pd

2018-06-27 Thread Jeff Law
On 06/27/2018 10:11 PM, Marc Glisse wrote: > (why is there no mention of ABSU_EXPR in doc/* ?) [ ... ] Kugan, Please address Marc's comments and repost. Marc, thanks for chiming in. jeff

Re: [ABSU_EXPR] Add some of the missing patterns in match,pd

2018-06-27 Thread Marc Glisse
(why is there no mention of ABSU_EXPR in doc/* ?) --- a/gcc/match.pd +++ b/gcc/match.pd @@ -571,10 +571,12 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (copysigns (op @0) @1) (copysigns @0 @1 -/* abs(x)*abs(x) -> x*x. Should be valid for all types. */ -(simplify - (mult (abs@1 @0) @1) -

Re: [ABSU_EXPR] Add some of the missing patterns in match,pd

2018-06-27 Thread Jeff Law
On 06/27/2018 06:25 PM, Kugan Vivekanandarajah wrote: > Hi, > > This patch adds some of the missing patterns in match.pd for ABSU_EXPR. > > Bootstrap and regression testing on x86_64-linux-gnu. Is this OK if no > regressions. > > Thanks, > Kugan > > gcc/ChangeLog: > > 2018-06-28 Kugan Vivekan