Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2015-06-16 Thread Christophe Lyon
On 16 June 2015 at 10:20, Christophe Lyon wrote: > On 15 June 2015 at 14:16, Christophe Lyon wrote: >> On 8 May 2015 at 12:42, Richard Biener wrote: >>> On Tue, Nov 4, 2014 at 11:44 AM, Marcus Shawcroft >>> wrote: On 25 September 2014 04:45, Michael Collison wrote: > On certain p

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2015-06-16 Thread Christophe Lyon
On 15 June 2015 at 14:16, Christophe Lyon wrote: > On 8 May 2015 at 12:42, Richard Biener wrote: >> On Tue, Nov 4, 2014 at 11:44 AM, Marcus Shawcroft >> wrote: >>> On 25 September 2014 04:45, Michael Collison >>> wrote: On certain patterns in atomics.md the constraint 'n' is used in combin

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2015-06-15 Thread Christophe Lyon
On 8 May 2015 at 12:42, Richard Biener wrote: > On Tue, Nov 4, 2014 at 11:44 AM, Marcus Shawcroft > wrote: >> On 25 September 2014 04:45, Michael Collison >> wrote: >>> On certain patterns in atomics.md the constraint 'n' is used in combination >>> with the predicate atomic_op_operand. The const

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2015-05-08 Thread Richard Biener
On Tue, Nov 4, 2014 at 11:44 AM, Marcus Shawcroft wrote: > On 25 September 2014 04:45, Michael Collison > wrote: >> On certain patterns in atomics.md the constraint 'n' is used in combination >> with the predicate atomic_op_operand. The constraint is too general and >> allows constants that are d

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-11-04 Thread Marcus Shawcroft
On 25 September 2014 04:45, Michael Collison wrote: > On certain patterns in atomics.md the constraint 'n' is used in combination > with the predicate atomic_op_operand. The constraint is too general and > allows constants that are disallowed by the predicate. This causes an ICE In > final_scan_in

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-10-09 Thread Christophe Lyon
On 25 September 2014 21:30, Segher Boessenkool wrote: > On Thu, Sep 25, 2014 at 10:33:17AM -0700, Michael Collison wrote: >> The problem is the "CONST_INT 0", not a large constant. This constant is >> not accepted by the predicate, but is accepted by the constraint. > > Yes, bad choice of words, s

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-25 Thread Segher Boessenkool
On Thu, Sep 25, 2014 at 10:33:17AM -0700, Michael Collison wrote: > The problem is the "CONST_INT 0", not a large constant. This constant is > not accepted by the predicate, but is accepted by the constraint. Yes, bad choice of words, sorry. Just read "big" as "not matching the predicate". The

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-25 Thread Michael Collison
Segher, The problem is the "CONST_INT 0", not a large constant. This constant is not accepted by the predicate, but is accepted by the constraint. On 09/25/2014 03:12 AM, Segher Boessenkool wrote: On Wed, Sep 24, 2014 at 09:17:23PM -0700, Andrew Pinski wrote: On Wed, Sep 24, 2014 at 9:13 PM,

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-25 Thread Segher Boessenkool
On Wed, Sep 24, 2014 at 09:17:23PM -0700, Andrew Pinski wrote: > On Wed, Sep 24, 2014 at 9:13 PM, Michael Collison > wrote: > > > > I have that attached to the bug report at the URL provided. I will work on a > > testcase if you think it is warranted. > > Yes it is almost always warranted. > > h

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-24 Thread Andrew Pinski
On Wed, Sep 24, 2014 at 9:13 PM, Michael Collison wrote: > > I have that attached to the bug report at the URL provided. I will work on a > testcase if you think it is warranted. Yes it is almost always warranted. https://gcc.gnu.org/contribute.html#patches Testcases If you cannot follow the

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-24 Thread Michael Collison
I have that attached to the bug report at the URL provided. I will work on a testcase if you think it is warranted. On 09/24/2014 09:10 PM, Andrew Pinski wrote: On Wed, Sep 24, 2014 at 9:08 PM, Michael Collison wrote: Testcase attaached. Reproduce with "g++ -c -O2 -fPIE". URL for more detai

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-24 Thread Andrew Pinski
On Wed, Sep 24, 2014 at 9:08 PM, Michael Collison wrote: > > Testcase attaached. Reproduce with "g++ -c -O2 -fPIE". URL for more detailed > description: > > https://bugs.linaro.org/show_bug.cgi?id=331 It would be a good idea to get a reduced testcase that you could add to the GCC testsuite so thi

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-24 Thread Michael Collison
Testcase attaached. Reproduce with "g++ -c -O2 -fPIE". URL for more detailed description: https://bugs.linaro.org/show_bug.cgi?id=331 On 09/24/2014 09:01 PM, Andrew Pinski wrote: On Wed, Sep 24, 2014 at 8:45 PM, Michael Collison wrote: On certain patterns in atomics.md the constraint 'n'

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2014-09-24 Thread Andrew Pinski
On Wed, Sep 24, 2014 at 8:45 PM, Michael Collison wrote: > On certain patterns in atomics.md the constraint 'n' is used in combination > with the predicate atomic_op_operand. The constraint is too general and > allows constants that are disallowed by the predicate. This causes an ICE In > final_sc